Merge lp://qastaging/~indicator-applet-developers/indicator-network/lp1220332 into lp://qastaging/indicator-network/13.10

Proposed by Antti Kaijanmäki
Status: Merged
Approved by: Ted Gould
Approved revision: 305
Merged at revision: 305
Proposed branch: lp://qastaging/~indicator-applet-developers/indicator-network/lp1220332
Merge into: lp://qastaging/indicator-network/13.10
Diff against target: 16 lines (+6/-0)
1 file modified
network/device-wifi.vala (+6/-0)
To merge this branch: bzr merge lp://qastaging/~indicator-applet-developers/indicator-network/lp1220332
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Pete Woods (community) Approve
Review via email: mp+191143@code.qastaging.launchpad.net

Commit message

Listen wireless-enabled signal. Fixes: https://bugs.launchpad.net/bugs/1220332.

To post a comment you must log in.
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

wireless-enabled is signaled on startup, also so no need to check it on constructor.

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

And yes. this is not a complete solution as all of the different <technology>-enabled properties should be listened for changes also including the hwkill signals. But let's just fix this one bug first.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:305
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~indicator-applet-developers/indicator-network/lp1220332/+merge/191143/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/indicator-network-ci/85/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-saucy-amd64-ci/75
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-saucy-armhf-ci/75
        deb: http://jenkins.qa.ubuntu.com/job/indicator-network-saucy-armhf-ci/75/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/indicator-network-ci/85/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Pete Woods (pete-woods) wrote :

Looks good to me, and seems to work!

But what a crazy way to have to use the API with the out variable, there! It's like a C programmer tried to implement a C#-like language.

review: Approve
Revision history for this message
Pete Woods (pete-woods) wrote :

(To be fair, C# does have this syntax, but you shouldn't use it in your APIs without a good reason, like you need a simple way to have multiple return values)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
Tony Espy (awe) wrote :

Tested on maguro / image #98 and works for me.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: