Merge lp://qastaging/~inkscape+alexander/inkscape/flatten into lp://qastaging/~inkscape.dev/inkscape/trunk

Stroke to Path should probably be renamed to make it more obvious that it will preserve fills. "Detach Stroke" perhaps.

Path -> Remove Overlap should not be in the menu but in the align and distribute interface. A button at the bottom with the other distribution and shuffling options.

Unlink Clones recursively is really long, maybe "Unlink All Clones" would be better and make sure it deals with both multiple selected objects and groups.

On 2015-06-02 07:56 (+0200), Martin Owens wrote:
> Path -> Remove Overlap should not be in the menu but in the align and
> distribute interface. A button at the bottom with the other
> distribution and shuffling options.

Path -> Remove Overlap is a (recursive) path operation which does not
change the position of the selected objects. IMvHO it should _not_ be
moved to the Align & Distribute dialog: None of the features in Align &
Distribute edit in any way the geometry of the aligned or distributed
objects; 'Path > Remove Overlap' however does edit the geometry of
overlapped objects (it subtracts the part overlapped by another object).

I agree with su_v here. I first imagined it was dealing in objects. Ignore that bit.

Although the align and distribute dialog does have path alignment options. We should consider expanding it from the 4 buttons it currently has.

On 02/06/15 07:56, Martin Owens wrote:
> Review: Needs Fixing ui review
>
> Stroke to Path should probably be renamed to make it more obvious that it will preserve fills. "Detach Stroke" perhaps.

I'm ok with that, how are decisions about such changes made in the
Inkscape project?

> Unlink Clones recursively is really long, maybe "Unlink All Clones" would be better and make sure it deals with both multiple selected objects and groups.

"Unlink All Clones" sounds to me like it would unlink any clone in the
document regardless of if it's selected or not.

It deals with clones of groups of clones of objects etc., does that
answer the question?

Changes in inkscape are done on trust and review. We can implement changes as we want, but we will also often review the changes for each other.

"Unlink Selected Clones" maybe?

Did this feature go into trunk already? Should we close this review?

> Did this feature go into trunk already? Should we close this review?

I built the latest Inkscape version from trunk (15146) and checked if the features I added are present in it.

These functions are present:

- Stroke to path now keeps the fill like I want it.

These aren't (or I couldn't find them):

- There's no function which unlinks clones even if they are in groups or clone of clones or similar.
- There is no function to intersect clipped paths with their clipping path
- There is no function for removing overlap of objects using difference operations (the resulting vector should look exactly like before but without overlapping areas)

I am willing to modify the code once more so it works with the current Inkscape trunk version if we can figure out the names for the functions so it can be merged and doesn't rot for another year.

I'm willing to get the requests merged. Although for each of the items, if they can be separated out, it makes it easier to review and test the new changes.

Thanks for having a look and comparing it to trunk.

I think only 1. is in trunk

> I'm willing to get the requests merged. Although for each of the items, if
> they can be separated out, it makes it easier to review and test the new
> changes.

I checked out current trunk and startet to port my features so it works with the current trunk. Some stuff in Inkscape::Selection was fundamentally changed, some of my old code works with g_slist-functions so it's more than copy-paste.

Unfortunately, RL shows its ugly face so this may take some time but I'm working on it.

Thanks for working on it, the selection code has been re-factored recently and several merge requests have gone through the same process of re-basing to trunk. You might be able to find some clues if you examine recent 'Merged' status merge requests.