Merge lp://qastaging/~inspirated/launchpad/export-Person-getBugSubscriberPackages into lp://qastaging/launchpad
Proposed by
Kamran Riaz Khan
Status: | Superseded | ||||||||
---|---|---|---|---|---|---|---|---|---|
Proposed branch: | lp://qastaging/~inspirated/launchpad/export-Person-getBugSubscriberPackages | ||||||||
Merge into: | lp://qastaging/launchpad | ||||||||
Diff against target: |
49 lines (+19/-0) 3 files modified
lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+4/-0) lib/lp/registry/interfaces/person.py (+2/-0) lib/lp/registry/stories/webservice/xx-person.txt (+13/-0) |
||||||||
To merge this branch: | bzr merge lp://qastaging/~inspirated/launchpad/export-Person-getBugSubscriberPackages | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Needs Fixing | |
Review via email: mp+27568@code.qastaging.launchpad.net |
This proposal has been superseded by a proposal from 2010-06-15.
Commit message
Exported Person.
Description of the change
Summary:
As part of my GSoC 2010 project, functionality is required in Arsenal to search all the bugs a team is subscribed to. This required an API call which would export all the source packages subscriptions of a team. Bug #281443 and Bug #331039 document other needs for this API call.
Proposed fix:
The method for searching a team's subscriptions is already present in lib/lp/
To post a comment you must log in.
Hi Kamran,
Thanks for making this change. Unfortunately before changes can be landed in Launchpad they must have tests to cover them. With your changes, the tests suite will at the moment almost certainly fail. You need to alter the existing tests to cover this change.
I haven't had time to run the whole test suite to check which tests fail, but you'll at least need to fix the tests in lib/lp/ registry/ stories/ webservice/ xx-person. txt (you can find out where the failures will be by running bin/test -cvvt xx-person from the root of your LP branch).
I'd be happy to help you with fixing the tests, just ping me in #launchpad-dev on Freenode and if I'm around I'll help you out.