Merge lp://qastaging/~intrigeri/apparmor-profiles/pidgin-vs-gstreamer-1.6 into lp://qastaging/apparmor-profiles

Proposed by intrigeri
Status: Merged
Merged at revision: 154
Proposed branch: lp://qastaging/~intrigeri/apparmor-profiles/pidgin-vs-gstreamer-1.6
Merge into: lp://qastaging/apparmor-profiles
Diff against target: 14 lines (+4/-0)
1 file modified
ubuntu/16.04/usr.bin.pidgin (+4/-0)
To merge this branch: bzr merge lp://qastaging/~intrigeri/apparmor-profiles/pidgin-vs-gstreamer-1.6
Reviewer Review Type Date Requested Status
Christian Boltz Approve
Review via email: mp+277499@code.qastaging.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
intrigeri (intrigeri) wrote :

6 weeks later: ping?

Revision history for this message
Christian Boltz (cboltz) wrote :

I never used pidgin, but the changes look sane and valid, therefore merged into r154.

I tend to think that all gstreamer-related rules should go into abstractions/gstreamer, but
a) that's something for a separate cleanup patch and
b) I don't really know gstreamer, so I'm not sure if all applications using gstreamer also need those permissions (if yes, moving to the abstraction makes sense)

review: Approve
Revision history for this message
intrigeri (intrigeri) wrote :

Christian Boltz wrote (30 Dec 2015 21:03:35 GMT) :
> I tend to think that all gstreamer-related rules should go into abstractions/gstreamer,

Agreed, added to my personal todo list for some day I don't feel like
doing this kind of things.

Cheers,
--
intrigeri

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: