lp://qastaging/~itachi-san/telegram-desktop/breakpad

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

1 recipe using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2206. By Leonard Grey <email address hidden> on 2024-12-02

Upload system symbols: ensure dumped breakpad filenames are unique

At some point, we started hitting limits on symbol file names, so we
began collapsing each path components except the filename down to the
first letter.

This breaks down with the following setup:
Some.framework/Versions/30/libSomething.dylib
Some.framework/Versions/31/libSomething.dylib

Which collapse to the same file name. Since upload_system_symbols
dumps in parallel, this can lead to one of the files overwriting
part of the other, creating a corrupted end product.

This change creates files with O_EXCL. If creating fails due to the
file already existing, we tack on a counter (so f.sym becomes f_1.sym,
for example).

Bug: chromium:40250422
Change-Id: I66ea50b84d68d3c5103eb7e31568b8444ec3be27
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/6064141
Reviewed-by: Mark Mentovai <email address hidden>

2205. By Mark Mentovai <email address hidden> on 2024-11-14

Fix #includes

 1. #include <abc.h> in preference to <cabc>
 2. In affected files, sort #includes according to modern practice
 3. Where #include order changes resulted in compile errors in other
    code, adhere to the principle of “include what you use”

Step 1 was achieved by the following snippet, plus manual inspection and
modification to move headers to the proper sections.

```
for f in $(git grep -l '^#(include|import) <c.*[^.].>'); do
  sed -E -i '' \
      -e 's/^#(include|import) <c(.*[^.].)>/#include <\2.h>/' \
      "$f"
done
```

Step 2 is achieved by the manual inspection and modification, followed
by `git cl format`.

Step 3 is manual, based on the results of a test build.

Change-Id: I7e43a7a534fab54b6c1d47e442a3573f28996151
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/6023410
Reviewed-by: Joshua Peraza <email address hidden>

2204. By Nico Weber on 2024-11-13

win: include stdlib.h for mbstowcs_s, wcstombs_s

This used to come in transitively via <vector>, but upstream libc++
cleaned up its <vector> a bit and this is no longer true with new
libc++ versions.

No behavior change.

Bug: chromium:376278210
Change-Id: I658f500cfd0e3a33c260d34302557b3ceb2799ca
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5994352
Reviewed-by: Mark Mentovai <email address hidden>

2203. By Nelson Billing <email address hidden> on 2024-10-30

Revert "[windows] dump_syms - Support ARM64 PDB"

This reverts commit e92bea30759edbae08205bccd14dc25bf1806f93.

Reason for revert: Causing crashes in symupload.exe for arm64 binaries.

Original change's description:
> [windows] dump_syms - Support ARM64 PDB
>
> Change-Id: I6a9cb5c5253abcd34cb72a035d280b7fd8a50372
> Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5836085
> Reviewed-by: Nelson Billing <email address hidden>

Change-Id: I32c96088213c1196f506580dbcb0b79dae945398
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5980968
Reviewed-by: Will Harris <email address hidden>

2202. By Rulong Chen（陈汝龙） <email address hidden> on 2024-10-30

Fix the compilation error

Bug: none
Change-Id: I823fe99720eb0bc22f08457e78766500b7bc82ad
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5975023
Reviewed-by: Ivan Penkov <email address hidden>

2201. By Rulong Chen（陈汝龙） <email address hidden> on 2024-10-29

Print additional argument that describes the crash

Bug: none
Change-Id: I94b1585d78387dc93efdaba2fa52eb71725a644e
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5974621
Reviewed-by: Ivan Penkov <email address hidden>
Reviewed-by: Ivan Penkov <email address hidden>

2200. By Takuto Ikuta <email address hidden> on 2024-10-28

dwarf: fix missing include for exit()

Bug: 375980422
Change-Id: I7f55c5ed74781becfaec0d79998676e9a984ffc5
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5970061
Reviewed-by: Lei Zhang <email address hidden>

2199. By Liryna <email address hidden> on 2024-09-04

[windows] dump_syms - Support ARM64 PDB

Change-Id: I6a9cb5c5253abcd34cb72a035d280b7fd8a50372
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5836085
Reviewed-by: Nelson Billing <email address hidden>

2198. By abrook <email address hidden> on 2024-09-04

Fix bugs with alternative section naming on mac, and unpropagated
section information.

Change-Id: I6f4e112a83aeee1e4cd525c1d1d0b9213ef2d09b
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5838157
Reviewed-by: Joshua Peraza <email address hidden>

2197. By Greg Thompson <email address hidden> on 2024-08-16

[windows] Silence MSVC warning C4100 when building without zlib support

Also correct the indentation of the Deflate function to match the
surrounding code.

Bug: b/354710760
Change-Id: I17e64b2f6390f673169a783e63505eb9df233a79
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5771532
Reviewed-by: Joshua Peraza <email address hidden>