Juju Charms Collection
ceph-radosgw package

Merge lp://qastaging/~ivoks/charms/trusty/ceph-radosgw/forbidden-exception into lp://qastaging/~openstack-charmers-archive/charms/trusty/ceph-radosgw/next

  1. Trusty Tahr (14.04)
  2. forbidden-exception
  3. Merge into next
Proposed by Ante Karamatić
Status: Merged
Merged at revision: 64
Proposed branch: lp://qastaging/~ivoks/charms/trusty/ceph-radosgw/forbidden-exception
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/ceph-radosgw/next
Diff against target: 32 lines (+9/-4)
1 file modified
hooks/hooks.py (+9/-4)
To merge this branch: bzr merge lp://qastaging/~ivoks/charms/trusty/ceph-radosgw/forbidden-exception
Reviewer Review Type Date Requested Status
Edward Hope-Morley Needs Fixing
Review via email: mp+286293@code.qastaging.launchpad.net

Description of the change

We've seen 403 (Forbidden) exception being raised with Liberty.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #735 ceph-radosgw-next for ivoks mp286293
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/735/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #643 ceph-radosgw-next for ivoks mp286293
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/643/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #289 ceph-radosgw-next for ivoks mp286293
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15099899/
Build: http://10.245.162.36:8080/job/charm_amulet_test/289/

Revision history for this message
Edward Hope-Morley (hopem) wrote :

lgtm +1 (amulet test failure is not related to this and is being resolved in a different patch)

review: Approve
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Actually I take that back. You need to import exceptions.Forbidden in both cases i.e. you want:

    try:
        # Kilo and newer
        from keystoneclient.exceptions import (
            ConnectionRefused,
            Forbidden
        )
    except ImportError:
        # Juno and older
        from keystoneclient.exceptions import (
            ConnectionError as ConnectionRefused,
            Forbidden
        )

review: Needs Fixing
Revision history for this message
Ryan Beisner (1chb1n) wrote :

FYI - Amulet tests will not pass (not passing @ next either) due to
https://bugs.launchpad.net/charms/+source/ceph-radosgw/+bug/1545179

Revision history for this message
Ryan Beisner (1chb1n) wrote :

I suggest we get that fix landed first, then rebase this, so we can get a clean test here.

lp://qastaging/~ivoks/charms/trusty/ceph-radosgw/forbidden-exception updated
64. By Ante Karamatić

Add Forbidden exception for Juno and older

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #747 ceph-radosgw-next for ivoks mp286293
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/15100328/
Build: http://10.245.162.36:8080/job/charm_lint_check/747/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #653 ceph-radosgw-next for ivoks mp286293
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/653/

lp://qastaging/~ivoks/charms/trusty/ceph-radosgw/forbidden-exception updated
65. By Ante Karamatić

Fix lint errors

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #655 ceph-radosgw-next for ivoks mp286293
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/655/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #749 ceph-radosgw-next for ivoks mp286293
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/749/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #301 ceph-radosgw-next for ivoks mp286293
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15100788/
Build: http://10.245.162.36:8080/job/charm_amulet_test/301/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #303 ceph-radosgw-next for ivoks mp286293
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15100909/
Build: http://10.245.162.36:8080/job/charm_amulet_test/303/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches