Merge lp://qastaging/~ivoks/charms/trusty/neutron-contrail/juju2-bridges into lp://qastaging/~sdn-charmers/charms/trusty/neutron-contrail/trunk
Proposed by
Ante Karamatić
| Status: | Rejected |
|---|---|
| Rejected by: | Robert Ayres |
| Proposed branch: | lp://qastaging/~ivoks/charms/trusty/neutron-contrail/juju2-bridges |
| Merge into: | lp://qastaging/~sdn-charmers/charms/trusty/neutron-contrail/trunk |
| Diff against target: |
148 lines (+48/-28) 5 files modified
config.yaml (+6/-3) hooks/neutron_contrail_hooks.py (+1/-1) hooks/neutron_contrail_utils.py (+5/-2) scripts/create-vrouter.sh (+17/-10) scripts/remove-juju-bridge.sh (+19/-12) |
| To merge this branch: | bzr merge lp://qastaging/~ivoks/charms/trusty/neutron-contrail/juju2-bridges |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Ayres (community) | Disapprove | ||
|
Review via email:
|
|||
Description of the change
This is by no standards a perfect code. However it shows the direction of what needs to be implemented. I'm not proud of 'sed' in that script, but I was tight on time to review that awk code.
This should all move to python.
Goal of these changes is to add support for MAAS/Juju 2.0 style of bridges for interfaces.
To post a comment you must log in.
Unmerged revisions
- 58. By Ante Karamatić
-
Fix config.yaml
- 57. By Ante Karamatić
-
Add support for Juju2-style bridges in MAAS 2.0.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for the original merge.
I've committed refactored vRouter code for Juju 2.0 here - http://