Merge lp://qastaging/~jameinel/juju-utils/timeit into lp://qastaging/juju-utils

Proposed by John A Meinel
Status: Needs review
Proposed branch: lp://qastaging/~jameinel/juju-utils/timeit
Merge into: lp://qastaging/juju-utils
Diff against target: 59 lines (+54/-0)
1 file modified
utils/timeit.go (+54/-0)
To merge this branch: bzr merge lp://qastaging/~jameinel/juju-utils/timeit
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+165294@code.qastaging.launchpad.net

Description of the change

Pulling the timeit functionality out of juju-core itself.
It still is the only thing that gives wallclock time for what functions you're blocking in.
The nesting can still be wrong with concurrent routines, but it still gives correct *time* just incorrect nesting of the output display.

We talked about moving this out into "juju-core-utils", but since you've already created juju-utils I figured I'd just use it.
The focus is slightly different (your's seems more executable vs library oriented), but it seems reasonable.

To post a comment you must log in.

Unmerged revisions

3. By John A Meinel

Add timeit from juju-core itself.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches