Merge lp://qastaging/~jameinel/tarmac/ensure-log-dir into lp://qastaging/tarmac
Proposed by
John A Meinel
| Status: | Merged |
|---|---|
| Approved by: | Paul Hummer |
| Approved revision: | 402 |
| Merged at revision: | 403 |
| Proposed branch: | lp://qastaging/~jameinel/tarmac/ensure-log-dir |
| Merge into: | lp://qastaging/tarmac |
| Diff against target: |
112 lines (+86/-0) 2 files modified
tarmac/log.py (+18/-0) tarmac/tests/test_log.py (+68/-0) |
| To merge this branch: | bzr merge lp://qastaging/~jameinel/tarmac/ensure-log-dir |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Hummer | Approve | ||
|
Review via email:
|
|||
Commit message
When starting up, make sure the logging directory exists before trying to log into it.
Description of the change
In using tarmac via a charm, I found that if you configure a logging directory that doesn't exist, it doesn't get created, and just doesn't do any logging.
This changes it so it tries to do 'os.makedirs' for the directory that it was requested to log in.
Mostly useful with the tarmac charm, because you would like to not ssh into that machine and manually set things up.
To post a comment you must log in.
Revision history for this message
| Paul Hummer (rockstar) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
