Merge lp://qastaging/~james-page/charm-helpers/bug-1703451 into lp://qastaging/charm-helpers

Proposed by James Page
Status: Merged
Approved by: Alex Kavanagh
Approved revision: 776
Merged at revision: 776
Proposed branch: lp://qastaging/~james-page/charm-helpers/bug-1703451
Merge into: lp://qastaging/charm-helpers
Diff against target: 111 lines (+51/-10)
2 files modified
charmhelpers/contrib/openstack/context.py (+18/-8)
tests/contrib/openstack/test_os_contexts.py (+33/-2)
To merge this branch: bzr merge lp://qastaging/~james-page/charm-helpers/bug-1703451
Reviewer Review Type Date Requested Status
Alex Kavanagh Approve
Review via email: mp+328503@code.qastaging.launchpad.net

Description of the change

Ensure that any end-user provided hostname configuration options are used
when configuring Apache SSL configuration for endpoint names.

This resolve a mismatch between the name of the cert and key files on disk
and the paths written into the apache configuration files.

To post a comment you must log in.
Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches