Charm Helpers

Merge lp://qastaging/~james-page/charm-helpers/cloud-source-improvements into lp://qastaging/charm-helpers

  1. cloud-source-improvements
  2. Merge into devel
Proposed by James Page
Status: Merged
Merged at revision: 91
Proposed branch: lp://qastaging/~james-page/charm-helpers/cloud-source-improvements
Merge into: lp://qastaging/charm-helpers
Diff against target: 98 lines (+64/-4)
2 files modified
charmhelpers/fetch/__init__.py (+30/-1)
tests/fetch/test_fetch.py (+34/-3)
To merge this branch: bzr merge lp://qastaging/~james-page/charm-helpers/cloud-source-improvements
Reviewer Review Type Date Requested Status
James Page Needs Resubmitting
Review via email: mp+183404@code.qastaging.launchpad.net

Description of the change

Three key changes:

1) Validation of supports cloud: sources

2) Support for openstack style cloud: sources (as found in openstack helpers)

e.g. cloud:precise-grizzly

3) Support for implicity distro series:

e.g. cloud:grizzly

To post a comment you must log in.
Revision history for this message
Adam Gandelman (gandelman-a) wrote :

This looks fine to me, but I wonder if we want to raise a fetch.SourceConfigError exception here with some context instead of a KeyError?

38 + actual_pocket = CLOUD_ARCHIVE_POCKETS[pocket]

lp://qastaging/~james-page/charm-helpers/cloud-source-improvements updated
78. By James Page

Add support for short version proposed, raise SourceConfigError when invalid pocket name is supplied

Revision history for this message
James Page (james-page) wrote :

Ready for re-review. I also added support for:

    cloud:havana/proposed

Style configurations.

review: Needs Resubmitting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches