Merge lp://qastaging/~james-page/charm-helpers/lp-1475247 into lp://qastaging/charm-helpers

Proposed by James Page
Status: Merged
Merged at revision: 424
Proposed branch: lp://qastaging/~james-page/charm-helpers/lp-1475247
Merge into: lp://qastaging/charm-helpers
Diff against target: 32 lines (+6/-4)
2 files modified
charmhelpers/contrib/storage/linux/utils.py (+3/-2)
tests/contrib/storage/test_linux_storage_utils.py (+3/-2)
To merge this branch: bzr merge lp://qastaging/~james-page/charm-helpers/lp-1475247
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
Adam Collard (community) Approve
Review via email: mp+265125@code.qastaging.launchpad.net

Description of the change

Split calls to sgdisk

Ceph identified a hang condition that is resolved by splitting the calls
to sgdisk into two calls - one with zap-disk and the other with
clear/mbrtogpt.

To post a comment you must log in.
Revision history for this message
Adam Collard (adam-collard) wrote :

Looks good, one minor comment about the... comment

review: Approve
409. By James Page

Reference commit

Revision history for this message
Chris Glass (tribaal) wrote :

+1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches