Merge lp://qastaging/~james-page/charms/precise/jenkins-slave/fixup into lp://qastaging/charms/jenkins-slave

Proposed by James Page
Status: Merged
Approved by: Juan L. Negron
Approved revision: 18
Merged at revision: 10
Proposed branch: lp://qastaging/~james-page/charms/precise/jenkins-slave/fixup
Merge into: lp://qastaging/charms/jenkins-slave
Diff against target: 107 lines (+24/-26)
6 files modified
CHANGES.md (+0/-11)
hooks/install (+12/-5)
hooks/install.d/README (+7/-0)
hooks/slave-relation-changed (+4/-5)
hooks/slave-relation-departed (+0/-4)
revision (+1/-1)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/precise/jenkins-slave/fixup
Reviewer Review Type Date Requested Status
Juan L. Negron (community) Approve
Review via email: mp+117433@code.qastaging.launchpad.net

Description of the change

* FIX: Fixup /etc/default/jenkins-slave configuration handling (changed from
  upstart override).
* FEATURE: Add hooks/install.d to allow charm to be extended.

To post a comment you must log in.
Revision history for this message
Juan L. Negron (negronjl) wrote :

Reviewing this now.

-Juan

Revision history for this message
Juan L. Negron (negronjl) wrote :

Thanks James.

Approved.

-Juan

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: