Merge lp://qastaging/~james-page/charms/trusty/ceph-osd/multijournal-fixes into lp://qastaging/~openstack-charmers-archive/charms/trusty/ceph-osd/next

Proposed by James Page
Status: Merged
Merged at revision: 60
Proposed branch: lp://qastaging/~james-page/charms/trusty/ceph-osd/multijournal-fixes
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/ceph-osd/next
Diff against target: 216 lines (+96/-20)
2 files modified
hooks/ceph.py (+42/-7)
hooks/ceph_hooks.py (+54/-13)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/trusty/ceph-osd/multijournal-fixes
Reviewer Review Type Date Requested Status
Chris MacNaughton (community) Approve
OpenStack Charmers Pending
Review via email: mp+284394@code.qastaging.launchpad.net

Description of the change

Fixup misc lint and rebase Peters changes for multi-journal support.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #17079 ceph-osd-next for james-page mp284394
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/17079/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #18331 ceph-osd-next for james-page mp284394
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/18331/

Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

Looks good to me:

ubuntu@juju-ss-machine-7:/var/lib/ceph/osd/ceph-0$ ls -al
total 60
...
lrwxrwxrwx 1 root root 58 Jan 29 08:01 journal -> /dev/disk/by-partuuid/f0b6c78c-228c-41bb-9143-782225231eb4

ubuntu@juju-ss-machine-7:/var/lib/ceph/osd/ceph-3$ ls -al
total 48
...
lrwxrwxrwx 1 root root 58 Jan 29 08:01 journal -> /dev/disk/by-partuuid/ebed4b43-3582-4352-b3eb-46b8e93bba2d

ubuntu@juju-ss-machine-7:/var/lib/ceph/osd/ceph-0$ ls -l /dev/vd*
brw-rw---- 1 root disk 253, 64 Jan 29 08:02 /dev/vde
brw-rw---- 1 root disk 253, 65 Jan 29 08:02 /dev/vde1
brw-rw---- 1 root disk 253, 80 Jan 29 08:02 /dev/vdf
brw-rw---- 1 root disk 253, 81 Jan 29 08:02 /dev/vdf1

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #9095 ceph-osd-next for james-page mp284394
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/9095/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches