Merge lp://qastaging/~james-page/charms/trusty/cinder-ceph/tox into lp://qastaging/~openstack-charmers-archive/charms/trusty/cinder-ceph/next

Proposed by James Page
Status: Merged
Merged at revision: 46
Proposed branch: lp://qastaging/~james-page/charms/trusty/cinder-ceph/tox
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/cinder-ceph/next
Diff against target: 156 lines (+71/-8)
7 files modified
.bzrignore (+3/-0)
.testr.conf (+8/-0)
requirements.txt (+11/-0)
test-requirements.txt (+8/-0)
tests/basic_deployment.py (+11/-7)
tox.ini (+29/-0)
unit_tests/test_cinder_hooks.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/trusty/cinder-ceph/tox
Reviewer Review Type Date Requested Status
Corey Bryant (community) Approve
Review via email: mp+276537@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Code looks good and I ran tests successfully (tox, make lint/test, and a subset of amulet tests).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches