Merge lp://qastaging/~james-page/charms/trusty/cinder/bug.1391784 into lp://qastaging/~openstack-charmers-archive/charms/trusty/cinder/next

Proposed by James Page
Status: Merged
Merged at revision: 69
Proposed branch: lp://qastaging/~james-page/charms/trusty/cinder/bug.1391784
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/cinder/next
Diff against target: 98 lines (+57/-2)
3 files modified
config.yaml (+12/-0)
hooks/cinder_hooks.py (+6/-2)
unit_tests/test_cluster_hooks.py (+39/-0)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/trusty/cinder/bug.1391784
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Approve
Liam Young (community) Approve
Review via email: mp+241514@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_lint_check #1001 cinder-next for james-page mp241514
    LINT OK: passed

LINT Results (max last 5 lines):
  I: config.yaml: option ssl_ca has no default value
  I: config.yaml: option config-flags has no default value
  I: config.yaml: option ssl_cert has no default value
  I: config.yaml: option os-internal-network has no default value
  I: config.yaml: option os-public-network has no default value

Full lint test output: http://paste.ubuntu.com/8960542/
Build: http://10.98.191.181:8080/job/charm_lint_check/1001/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_unit_test #836 cinder-next for james-page mp241514
    UNIT OK: passed

UNIT Results (max last 5 lines):
  hooks/cinder_hooks 195 6 97% 99-100, 115, 122, 288-289
  hooks/cinder_utils 173 14 92% 191, 410-415, 452-464
  TOTAL 420 26 94%
  Ran 87 tests in 6.270s
  OK

Full unit test output: http://paste.ubuntu.com/8960545/
Build: http://10.98.191.181:8080/job/charm_unit_test/836/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_amulet_test #381 cinder-next for james-page mp241514
    AMULET FAIL: amulet-test failed

AMULET Results (max last 5 lines):
  juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv07"
  WARNING cannot delete security group "juju-osci-sv07-0". Used by another environment?
  juju-test INFO : Results: 2 passed, 1 failed, 0 errored
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/8960864/
Build: http://10.98.191.181:8080/job/charm_amulet_test/381/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1074 cinder-next for james-page mp241514
    LINT OK: passed

LINT Results (max last 5 lines):
  I: config.yaml: option ssl_ca has no default value
  I: config.yaml: option config-flags has no default value
  I: config.yaml: option ssl_cert has no default value
  I: config.yaml: option os-internal-network has no default value
  I: config.yaml: option os-public-network has no default value

Full lint test output: http://paste.ubuntu.com/9043275/
Build: http://10.98.191.181:8080/job/charm_lint_check/1074/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #908 cinder-next for james-page mp241514
    UNIT OK: passed

UNIT Results (max last 5 lines):
  hooks/cinder_hooks 195 6 97% 99-100, 115, 122, 288-289
  hooks/cinder_utils 173 14 92% 191, 410-415, 452-464
  TOTAL 420 26 94%
  Ran 87 tests in 5.528s
  OK

Full unit test output: http://paste.ubuntu.com/9043278/
Build: http://10.98.191.181:8080/job/charm_unit_test/908/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #416 cinder-next for james-page mp241514
    AMULET FAIL: amulet-test failed

AMULET Results (max last 5 lines):
  juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv07"
  WARNING cannot delete security group "juju-osci-sv07-0". Used by another environment?
  juju-test INFO : Results: 1 passed, 2 failed, 0 errored
  ERROR subprocess encountered error code 2
  make: *** [test] Error 2

Full amulet test output: http://paste.ubuntu.com/9043596/
Build: http://10.98.191.181:8080/job/charm_amulet_test/416/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1154 cinder-next for james-page mp241514
    LINT OK: passed

LINT Results (max last 5 lines):
  I: config.yaml: option ssl_ca has no default value
  I: config.yaml: option config-flags has no default value
  I: config.yaml: option ssl_cert has no default value
  I: config.yaml: option os-internal-network has no default value
  I: config.yaml: option os-public-network has no default value

Full lint test output: http://paste.ubuntu.com/9126481/
Build: http://10.98.191.181:8080/job/charm_lint_check/1154/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #988 cinder-next for james-page mp241514
    UNIT OK: passed

UNIT Results (max last 5 lines):
  hooks/cinder_hooks 195 6 97% 99-100, 115, 122, 288-289
  hooks/cinder_utils 173 14 92% 191, 410-415, 452-464
  TOTAL 420 26 94%
  Ran 87 tests in 6.270s
  OK

Full unit test output: http://paste.ubuntu.com/9126492/
Build: http://10.98.191.181:8080/job/charm_unit_test/988/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #496 cinder-next for james-page mp241514
    AMULET FAIL: amulet-test failed

AMULET Results (max last 5 lines):
  subprocess.CalledProcessError: Command '['juju-deployer', '-W', '-L', '-c', '/tmp/amulet-juju-deployer-H1LWry.json', '-e', 'osci-sv07', '-t', '1000', 'osci-sv07']' returned non-zero exit status 1
  WARNING cannot delete security group "juju-osci-sv07-0". Used by another environment?
  juju-test INFO : Results: 0 passed, 2 failed, 1 errored
  ERROR subprocess encountered error code 2
  make: *** [test] Error 2

Full amulet test output: http://paste.ubuntu.com/9127186/
Build: http://10.98.191.181:8080/job/charm_amulet_test/496/

Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #726 cinder-next for james-page mp241514
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/726/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #755 cinder-next for james-page mp241514
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/755/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #911 cinder-next for james-page mp241514
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/911/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

FYI P, T & U deploy tests are good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches