Juju Charms Collection
cinder package

Merge lp://qastaging/~james-page/charms/trusty/cinder/fixup-allowed-unit-migration into lp://qastaging/~openstack-charmers-archive/charms/trusty/cinder/next

  1. Trusty Tahr (14.04)
  2. fixup-allowed-unit-migration
  3. Merge into next
Proposed by James Page
Status: Merged
Merged at revision: 89
Proposed branch: lp://qastaging/~james-page/charms/trusty/cinder/fixup-allowed-unit-migration
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/cinder/next
Diff against target: 41 lines (+15/-5)
2 files modified
hooks/cinder_hooks.py (+6/-5)
unit_tests/test_cinder_hooks.py (+9/-0)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/trusty/cinder/fixup-allowed-unit-migration
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Adam Collard (community) Approve
Review via email: mp+256953@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Adam Collard (adam-collard) wrote :

2 minor comments inline

review: Approve
lp://qastaging/~james-page/charms/trusty/cinder/fixup-allowed-unit-migration updated
90. By James Page

Fixup based on feedback

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #3687 cinder-next for james-page mp256953
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/3687/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #3474 cinder-next for james-page mp256953
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/3474/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #3482 cinder-next for james-page mp256953
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/3482/

Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches