Merge lp://qastaging/~james-page/charms/trusty/neutron-gateway/xenial into lp://qastaging/~openstack-charmers-archive/charms/trusty/neutron-gateway/next

Proposed by James Page
Status: Merged
Merged at revision: 164
Proposed branch: lp://qastaging/~james-page/charms/trusty/neutron-gateway/xenial
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/neutron-gateway/next
Diff against target: 94 lines (+61/-10)
2 files modified
templates/mitaka/nova.conf (+34/-0)
tests/basic_deployment.py (+27/-10)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/trusty/neutron-gateway/xenial
Reviewer Review Type Date Requested Status
David Ames (community) Approve
Ryan Beisner (community) Approve
Review via email: mp+285862@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #375 neutron-gateway-next for james-page mp285862
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/375/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #298 neutron-gateway-next for james-page mp285862
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/298/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #149 neutron-gateway-next for james-page mp285862
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
2016-02-12 18:43:55,513 validate_config_data DEBUG: Validating config file data (fwaas in /etc/neutron/fwaas_driver.ini on neutron-gateway/0)...
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15027737/
Build: http://10.245.162.36:8080/job/charm_amulet_test/149/

Revision history for this message
David Ames (thedac) wrote :

This one also seems legit. I could not root cause it yet.

review: Needs Fixing
166. By James Page

Drop ec2 and objectstore checks for now

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #727 neutron-gateway-next for james-page mp285862
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/727/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #634 neutron-gateway-next for james-page mp285862
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/634/

167. By James Page

Fixup checks for neutron section in nova.conf

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #730 neutron-gateway-next for james-page mp285862
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/730/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #637 neutron-gateway-next for james-page mp285862
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/637/

168. By James Page

Fixup endpoint checks

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #744 neutron-gateway-next for james-page mp285862
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/744/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #650 neutron-gateway-next for james-page mp285862
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/650/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #281 neutron-gateway-next for james-page mp285862
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
2016-02-17 12:28:15,418 _validate_dict_data DEBUG: expected: {'quantum_port': '9696', 'auth_port': '35357', 'auth_protocol': 'http', 'keystone_host': <bound method OpenStackAmuletUtils.valid_ip of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'auth_host': <bound method OpenStackAmuletUtils.valid_ip of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'service_username': 'nova', 'service_tenant_name': 'services', 'service_protocol': 'http', 'service_tenant': 'services', 'quantum_url': <bound method OpenStackAmuletUtils.valid_url of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'service_password': <bound method OpenStackAmuletUtils.not_null of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'service_port': '5000', 'region': 'RegionOne', 'quantum_host': <bound method OpenStackAmuletUtils.valid_ip of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'private-address': <bound method OpenStackAmuletUtils.valid_ip of <charmhelpers.contrib.openstack.amulet.utils.OpenStackAmuletUtils object at 0x2b9bdd05d590>>, 'quantum_plugin': 'ovs'}
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15099836/
Build: http://10.245.162.36:8080/job/charm_amulet_test/281/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #284 neutron-gateway-next for james-page mp285862
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
juju-test.conductor.019-basic-trusty-mitaka DEBUG : Got exit code: 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15099927/
Build: http://10.245.162.36:8080/job/charm_amulet_test/284/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #297 neutron-gateway-next for james-page mp285862
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/297/

Revision history for this message
Ryan Beisner (1chb1n) :
review: Approve
Revision history for this message
David Ames (thedac) wrote :

LGTM, merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches