Merge lp://qastaging/~james-page/charms/trusty/neutron-openvswitch/liberty-arp-spoofing into lp://qastaging/~openstack-charmers-archive/charms/trusty/neutron-openvswitch/next

Proposed by James Page
Status: Merged
Approved by: David Ames
Approved revision: 110
Merged at revision: 106
Proposed branch: lp://qastaging/~james-page/charms/trusty/neutron-openvswitch/liberty-arp-spoofing
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/neutron-openvswitch/next
Diff against target: 120 lines (+59/-2)
5 files modified
README.md (+1/-1)
config.yaml (+9/-0)
hooks/neutron_ovs_context.py (+1/-0)
templates/liberty/ml2_conf.ini (+44/-0)
unit_tests/test_neutron_ovs_context.py (+4/-1)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/trusty/neutron-openvswitch/liberty-arp-spoofing
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Needs Information
OpenStack Charmers Pending
Review via email: mp+285577@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

One very tiny spelling comment below, and a question about Kilo.

Let us spoof on!

review: Needs Information
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #142 neutron-openvswitch-next for james-page mp285577
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/142/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #133 neutron-openvswitch-next for james-page mp285577
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/133/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #29 neutron-openvswitch-next for james-page mp285577
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/29/

109. By James Page

Fixup typo

110. By James Page

Update README for this change

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #138 neutron-openvswitch-next for james-page mp285577
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/138/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #151 neutron-openvswitch-next for james-page mp285577
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/151/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #90 neutron-openvswitch-next for james-page mp285577
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/90/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches