Merge lp://qastaging/~james-page/charms/trusty/nova-cloud-controller/bug.1391784 into lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next

Proposed by James Page
Status: Merged
Merged at revision: 136
Proposed branch: lp://qastaging/~james-page/charms/trusty/nova-cloud-controller/bug.1391784
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next
Diff against target: 94 lines (+49/-2)
3 files modified
config.yaml (+12/-0)
hooks/nova_cc_hooks.py (+6/-2)
unit_tests/test_nova_cc_hooks.py (+31/-0)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/trusty/nova-cloud-controller/bug.1391784
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Approve
Liam Young (community) Approve
Review via email: mp+241525@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_lint_check #1005 nova-cloud-controller-next for james-page mp241525
    LINT OK: passed

LINT Results (max last 5 lines):
  I: config.yaml: option haproxy-client-timeout has no default value
  I: config.yaml: option ssl_cert has no default value
  I: config.yaml: option nvp-l3-uuid has no default value
  I: config.yaml: option os-internal-network has no default value
  I: config.yaml: option nvp-controllers has no default value

Full lint test output: http://paste.ubuntu.com/8961144/
Build: http://10.98.191.181:8080/job/charm_lint_check/1005/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_unit_test #840 nova-cloud-controller-next for james-page mp241525
    UNIT OK: passed

UNIT Results (max last 5 lines):
  hooks/nova_cc_hooks 443 126 72% 132-135, 148-149, 173, 184-185, 189, 221, 226-231, 242, 322-325, 333-336, 342-345, 355-371, 380-382, 392-406, 410-419, 505, 515, 519-520, 573, 579-589, 594-605, 615-625, 641-642, 683-698, 706-710, 735-744, 768, 773-781, 807, 857-860
  hooks/nova_cc_utils 447 112 75% 296-301, 312-315, 325-326, 382, 384, 430-432, 436, 450-458, 465-470, 474-488, 548, 597-599, 604-607, 612, 616, 640-641, 655-657, 678-679, 685-708, 712-718, 722-728, 734, 740, 747, 758-762, 847, 907-913, 917-919, 923-926, 930-942
  TOTAL 1041 347 67%
  Ran 97 tests in 9.644s
  OK

Full unit test output: http://paste.ubuntu.com/8961150/
Build: http://10.98.191.181:8080/job/charm_unit_test/840/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_amulet_test #385 nova-cloud-controller-next for james-page mp241525
    AMULET OK: passed

AMULET Results (max last 5 lines):
  juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv04"
  WARNING cannot delete security group "juju-osci-sv04-0". Used by another environment?
  WARNING cannot delete security group "juju-osci-sv04". Used by another environment?
  WARNING cannot delete security group "juju-osci-sv04-0". Used by another environment?
  juju-test INFO : Results: 3 passed, 0 failed, 0 errored

Full amulet test output: http://paste.ubuntu.com/8961383/
Build: http://10.98.191.181:8080/job/charm_amulet_test/385/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1079 nova-cloud-controller-next for james-page mp241525
    LINT OK: passed

LINT Results (max last 5 lines):
  I: config.yaml: option haproxy-client-timeout has no default value
  I: config.yaml: option ssl_cert has no default value
  I: config.yaml: option nvp-l3-uuid has no default value
  I: config.yaml: option os-internal-network has no default value
  I: config.yaml: option nvp-controllers has no default value

Full lint test output: http://paste.ubuntu.com/9044320/
Build: http://10.98.191.181:8080/job/charm_lint_check/1079/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #913 nova-cloud-controller-next for james-page mp241525
    UNIT OK: passed

UNIT Results (max last 5 lines):
  hooks/nova_cc_hooks 443 126 72% 132-135, 148-149, 173, 184-185, 189, 221, 226-231, 242, 322-325, 333-336, 342-345, 355-371, 380-382, 392-406, 410-419, 505, 515, 519-520, 573, 579-589, 594-605, 615-625, 641-642, 683-698, 706-710, 735-744, 768, 773-781, 807, 857-860
  hooks/nova_cc_utils 447 112 75% 296-301, 312-315, 325-326, 382, 384, 430-432, 436, 450-458, 465-470, 474-488, 548, 597-599, 604-607, 612, 616, 640-641, 655-657, 678-679, 685-708, 712-718, 722-728, 734, 740, 747, 758-762, 847, 907-913, 917-919, 923-926, 930-942
  TOTAL 1041 347 67%
  Ran 97 tests in 9.171s
  OK

Full unit test output: http://paste.ubuntu.com/9044322/
Build: http://10.98.191.181:8080/job/charm_unit_test/913/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #421 nova-cloud-controller-next for james-page mp241525
    AMULET OK: passed

AMULET Results (max last 5 lines):
  juju-test.conductor.15-basic-trusty-icehouse RESULT :
  juju-test.conductor DEBUG : Tearing down osci-sv02 juju environment
  juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv02"
  WARNING cannot delete security group "juju-osci-sv02-0". Used by another environment?
  juju-test INFO : Results: 3 passed, 0 failed, 0 errored

Full amulet test output: http://paste.ubuntu.com/9044577/
Build: http://10.98.191.181:8080/job/charm_amulet_test/421/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_lint_check #1158 nova-cloud-controller-next for james-page mp241525
    LINT OK: passed

LINT Results (max last 5 lines):
  I: config.yaml: option haproxy-client-timeout has no default value
  I: config.yaml: option ssl_cert has no default value
  I: config.yaml: option nvp-l3-uuid has no default value
  I: config.yaml: option os-internal-network has no default value
  I: config.yaml: option nvp-controllers has no default value

Full lint test output: http://paste.ubuntu.com/9126505/
Build: http://10.98.191.181:8080/job/charm_lint_check/1158/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_unit_test #992 nova-cloud-controller-next for james-page mp241525
    UNIT OK: passed

UNIT Results (max last 5 lines):
  hooks/nova_cc_hooks 443 126 72% 132-135, 148-149, 173, 184-185, 189, 221, 226-231, 242, 322-325, 333-336, 342-345, 355-371, 380-382, 392-406, 410-419, 505, 515, 519-520, 573, 579-589, 594-605, 615-625, 641-642, 683-698, 706-710, 735-744, 768, 773-781, 807, 857-860
  hooks/nova_cc_utils 447 112 75% 296-301, 312-315, 325-326, 382, 384, 430-432, 436, 450-458, 465-470, 474-488, 548, 597-599, 604-607, 612, 616, 640-641, 655-657, 678-679, 685-708, 712-718, 722-728, 734, 740, 747, 758-762, 847, 907-913, 917-919, 923-926, 930-942
  TOTAL 1041 347 67%
  Ran 97 tests in 9.603s
  OK

Full unit test output: http://paste.ubuntu.com/9126520/
Build: http://10.98.191.181:8080/job/charm_unit_test/992/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

UOSCI bot says:
charm_amulet_test #500 nova-cloud-controller-next for james-page mp241525
    AMULET FAIL: amulet-test failed

AMULET Results (max last 5 lines):
  ERROR waited for 10m0s without being able to connect: ssh: connect to host 10.212.2.249 port 22: No route to host
  juju-test.conductor WARNING : Could not bootstrap osci-sv02, got Bootstrap returned with an exit > 0. Skipping
  juju-test INFO : Results: 1 passed, 1 failed, 1 errored
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/9127032/
Build: http://10.98.191.181:8080/job/charm_amulet_test/500/

Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #730 nova-cloud-controller-next for james-page mp241525
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/730/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #759 nova-cloud-controller-next for james-page mp241525
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/759/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #915 nova-cloud-controller-next for james-page mp241525
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/915/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

FYI P, T & U deploy tests are good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches