Merge lp://qastaging/~james-page/charms/trusty/nova-compute/network-splits into lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next

Proposed by James Page
Status: Merged
Merged at revision: 73
Proposed branch: lp://qastaging/~james-page/charms/trusty/nova-compute/network-splits
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next
Diff against target: 82 lines (+27/-8)
4 files modified
.bzrignore (+2/-0)
Makefile (+11/-6)
config.yaml (+10/-0)
hooks/nova_compute_context.py (+4/-2)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/trusty/nova-compute/network-splits
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
James Page Needs Resubmitting
Review via email: mp+228148@code.qastaging.launchpad.net

Description of the change

Add support for multiple network configuration.

To post a comment you must log in.
76. By James Page

Rebase

Revision history for this message
Liam Young (gnuoy) wrote :

Getting text conflicts

Contents conflict in charm-helpers.yaml
Conflict adding file hooks/charmhelpers/contrib/network/ip.py. Moved existing file to hooks/charmhelpers/contrib/network/ip.py.moved.
Conflict adding file hooks/charmhelpers/contrib/openstack/amulet. Moved existing file to hooks/charmhelpers/contrib/openstack/amulet.moved.
Text conflict in hooks/charmhelpers/contrib/openstack/context.py
Conflict adding file hooks/charmhelpers/contrib/openstack/ip.py. Moved existing file to hooks/charmhelpers/contrib/openstack/ip.py.moved.
Conflict adding file hooks/charmhelpers/core/fstab.py. Moved existing file to hooks/charmhelpers/core/fstab.py.moved.
7 conflicts encountered.

review: Needs Fixing
77. By James Page

Rebase and resync

Revision history for this message
James Page (james-page) :
review: Needs Resubmitting
Revision history for this message
Liam Young (gnuoy) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches