Merge lp://qastaging/~james-page/charms/trusty/percona-cluster/network-splits into lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/trunk

Proposed by James Page
Status: Merged
Merged at revision: 34
Proposed branch: lp://qastaging/~james-page/charms/trusty/percona-cluster/network-splits
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/trunk
Diff against target: 556 lines (+287/-74)
11 files modified
.bzrignore (+2/-0)
Makefile (+10/-7)
charm-helpers.yaml (+1/-0)
config.yaml (+45/-36)
hooks/charmhelpers/contrib/hahelpers/cluster.py (+3/-2)
hooks/charmhelpers/contrib/network/ip.py (+156/-0)
hooks/charmhelpers/core/hookenv.py (+5/-4)
hooks/charmhelpers/core/host.py (+11/-5)
hooks/charmhelpers/fetch/__init__.py (+23/-15)
hooks/percona_hooks.py (+30/-4)
hooks/percona_utils.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/trusty/percona-cluster/network-splits
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
James Page Needs Resubmitting
Review via email: mp+228151@code.qastaging.launchpad.net

Description of the change

Add support for separate 'access-network' configuration.

To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

See inline comment

review: Needs Fixing
Revision history for this message
James Page (james-page) :
review: Needs Resubmitting
Revision history for this message
Liam Young (gnuoy) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: