Juju Charms Collection
rabbitmq-server package

Merge lp://qastaging/~james-page/charms/trusty/rabbitmq-server/tox-switchover into lp://qastaging/~openstack-charmers-archive/charms/trusty/rabbitmq-server/next

  1. Trusty Tahr (14.04)
  2. tox-switchover
  3. Merge into next
Proposed by James Page
Status: Merged
Merged at revision: 131
Proposed branch: lp://qastaging/~james-page/charms/trusty/rabbitmq-server/tox-switchover
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/rabbitmq-server/next
Diff against target: 252 lines (+77/-53)
8 files modified
.bzrignore (+2/-0)
.testr.conf (+8/-0)
Makefile (+6/-17)
requirements.txt (+12/-0)
test-requirements.txt (+8/-5)
tox.ini (+29/-0)
unit_tests/__init__.py (+3/-0)
unit_tests/test_rabbitmq_server_relations.py (+9/-31)
To merge this branch: bzr merge lp://qastaging/~james-page/charms/trusty/rabbitmq-server/tox-switchover
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Approve
Liam Young (community) Approve
Review via email: mp+286139@code.qastaging.launchpad.net
To post a comment you must log in.
lp://qastaging/~james-page/charms/trusty/rabbitmq-server/tox-switchover updated
133. By James Page

Further makefile tidy

Revision history for this message
Liam Young (gnuoy) wrote :

LGTM but I'd like to make sure that the osci initiated tests work

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #566 rabbitmq-server-next for james-page mp286139
    UNIT FAIL: unit-test missing

UNIT Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full unit test output: http://paste.ubuntu.com/15089617/
Build: http://10.245.162.36:8080/job/charm_unit_test/566/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #655 rabbitmq-server-next for james-page mp286139
    LINT FAIL: lint-test missing

LINT Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full lint test output: http://paste.ubuntu.com/15089618/
Build: http://10.245.162.36:8080/job/charm_lint_check/655/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #262 rabbitmq-server-next for james-page mp286139
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
2016-02-16 11:36:04,819 publish_amqp_message_by_unit DEBUG: Publishing message...
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15090573/
Build: http://10.245.162.36:8080/job/charm_amulet_test/262/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

FYI, adjusting automation to be tox aware, will re-trigger unit and lint.

RE: amulet, one of the rmq units never reached "ready" state, will also retrigger.

rabbitmq-server/2 maintenance executing 1.25.3 6 5671/tcp,5672/tcp 172.17.104.67 (config-changed) Random wait for restart to avoid collisions

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #567 rabbitmq-server-next for james-page mp286139
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/567/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #657 rabbitmq-server-next for james-page mp286139
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/657/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #263 rabbitmq-server-next for james-page mp286139
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
2016-02-16 15:11:51,342 connect_amqp_by_unit DEBUG: Connecting to amqp on 172.17.105.185:5672 (rabbitmq-server/0) as testuser1...
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15092486/
Build: http://10.245.162.36:8080/job/charm_amulet_test/263/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

I think your test is hitting this. It's definitely unrelated to the proposed changes.

https://bugs.launchpad.net/charms/+source/rabbitmq-server/+bug/1546255

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches