Merge lp://qastaging/~james-page/simplestreams/virt-openstack into lp://qastaging/simplestreams

Proposed by James Page
Status: Merged
Merged at revision: 426
Proposed branch: lp://qastaging/~james-page/simplestreams/virt-openstack
Merge into: lp://qastaging/simplestreams
Diff against target: 44 lines (+15/-2)
2 files modified
simplestreams/mirrors/glance.py (+13/-1)
tools/sstream-mirror-glance (+2/-1)
To merge this branch: bzr merge lp://qastaging/~james-page/simplestreams/virt-openstack
Reviewer Review Type Date Requested Status
Scott Moser (community) Needs Fixing
Review via email: mp+289617@code.qastaging.launchpad.net

Description of the change

Switch to using virt key for hypervisor type in stream data.

To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :

you have a '--hypervisor-mapping' flag, that says":
help="Set hypervisor_type attribute on stored images. This is useful in OpenStack Clouds which use multiple hypervisor types with in a single region."

Should we change this '--hypervisor-mapping' to be '--virt-mapping'?

At very lease we need to change help text to reference 'virt'.

Is there a bug for this? that'll be helpful for uploading to xenial.

Revision history for this message
Scott Moser (smoser) :
review: Needs Fixing
428. By James Page

Update help message to detail setting of virt key in stream data for hypervisor-mapping

Revision history for this message
James Page (james-page) wrote :

I was also thinking that we should set the value in the stream data to something more end-user consumable - currently is lxc or qemu, but I suspect that lxd or kvm is probably nicer...

429. By James Page

Ensure that virt attribute is high level virtualization type, rather and low level hypervisor type

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: