work-items-tracker

Merge lp://qastaging/~james-w/launchpad-work-items-tracker/templates into lp://qastaging/launchpad-work-items-tracker

  1. templates
  2. Merge into trunk
Proposed by James Westby
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp://qastaging/~james-w/launchpad-work-items-tracker/templates
Merge into: lp://qastaging/launchpad-work-items-tracker
Prerequisite: lp://qastaging/~james-w/launchpad-work-items-tracker/locking
Diff against target: 738 lines (+412/-247)
7 files modified
.bzrignore (+1/-0)
.testr.conf (+3/-0)
html-report (+140/-247)
report_tools.py (+8/-0)
templates/burndown.html (+243/-0)
templates/test.html (+1/-0)
tests.py (+16/-0)
To merge this branch: bzr merge lp://qastaging/~james-w/launchpad-work-items-tracker/templates
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
Review via email: mp+48841@code.qastaging.launchpad.net

Description of the change

Hi,

This branch uses a template system to generate the HTML page. This
allows for better separation between data and presentation, and will allow
for greater code re-use. I also find it easier to produce valid HTML with
the template.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Note, this requires the external python-mako module, which isn't installed on people.canonical.com. Do we really need this functionality? Wouldn't it be enough to replace every ${varname} in template with data[varname] in fill_template()?

review: Needs Information
Revision history for this message
Martin Pitt (pitti) wrote :

Ah, that wouldn't cover the "%if" and "%for" expressions, sorry.

Revision history for this message
Martin Pitt (pitti) wrote :

This broke the blueprint status column, as there is no "has_status". I just removed the if, as bp.status always exists, and merged into lp:~work-items-tracker-hackers/launchpad-work-items-tracker/blueprints-api.

If we want this rolled out, we need to get python-mako installed on lillypilly. I sent an RT ticket to request this.

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: