Merge lp://qastaging/~james-w/launchpad/improve-makeDistroArchSeries into lp://qastaging/launchpad

Proposed by James Westby
Status: Work in progress
Proposed branch: lp://qastaging/~james-w/launchpad/improve-makeDistroArchSeries
Merge into: lp://qastaging/launchpad
Prerequisite: lp://qastaging/~james-w/launchpad/no-more-sampledata-2
Diff against target: 100 lines (+29/-10)
5 files modified
lib/lp/soyuz/interfaces/distroarchseries.py (+0/-3)
lib/lp/soyuz/model/distroarchseries.py (+0/-5)
lib/lp/soyuz/tests/test_publishing.py (+1/-1)
lib/lp/testing/factory.py (+3/-1)
lib/lp/testing/tests/test_factory.py (+25/-0)
To merge this branch: bzr merge lp://qastaging/~james-w/launchpad/improve-makeDistroArchSeries
Reviewer Review Type Date Requested Status
Jonathan Lange (community) Approve
Review via email: mp+31910@code.qastaging.launchpad.net

Commit message

makeDistroArchSeries now creates a new ProcessorFamily and ensures that it has at least one processor.

Description of the change

Hi,

A small change around makeDistroArchSeries:

  1. Test the method.
  2. remove an unused attribute that prevents verifyObject from passing.
  3. Have the method create a ProcessorFamily rather than using sampledata, and ensure there is at least one processor in that family.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

Thanks so much !

review: Approve
11320. By James Westby

Merged no-more-sampledata-2 into improve-makeDistroArchSeries.

11321. By James Westby

Merged no-more-sampledata-2 into improve-makeDistroArchSeries.

11322. By James Westby

Remove the unused component from the parameters.

11323. By James Westby

Merged no-more-sampledata-2 into improve-makeDistroArchSeries.

11324. By James Westby

Merge no-more-sampledata-2 in to improve-makeDistroArchSeries.

Unmerged revisions

11324. By James Westby

Merge no-more-sampledata-2 in to improve-makeDistroArchSeries.

11323. By James Westby

Merged no-more-sampledata-2 into improve-makeDistroArchSeries.

11322. By James Westby

Remove the unused component from the parameters.

11321. By James Westby

Merged no-more-sampledata-2 into improve-makeDistroArchSeries.

11320. By James Westby

Merged no-more-sampledata-2 into improve-makeDistroArchSeries.

11319. By James Westby

This improves makeDistroArchSeries, having it create a ProcessorFamily.

It also drops a badly implemented and unused attribute from DistroArchSeries.

11318. By James Westby

Merged soyuz-factory-improvements into no-more-sampledata-2.

11317. By James Westby

Clean up lint.

11316. By James Westby

Fix a mistaken change.

11315. By James Westby

Undo the layer change as it is no longer needed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.