Merge lp://qastaging/~james-w/linaro-image-tools/config-docs into lp://qastaging/linaro-image-tools/11.11
Proposed by
James Westby
| Status: | Merged |
|---|---|
| Approved by: | Michael Hudson-Doyle |
| Approved revision: | 52 |
| Merged at revision: | 35 |
| Proposed branch: | lp://qastaging/~james-w/linaro-image-tools/config-docs |
| Merge into: | lp://qastaging/linaro-image-tools/11.11 |
| Diff against target: |
77 lines (+26/-22) 1 file modified
hwpack/config.py (+26/-22) |
| To merge this branch: | bzr merge lp://qastaging/~james-w/linaro-image-tools/config-docs |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Hudson-Doyle (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Hi,
Here are the fixes you suggested on the last merge.
Thanks,
James
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good, thanks. Maaaybe _get_main_option could have a docstring and maybe its name is a bit generic (although it is my fault). Otherwise, +1