Linaro Image Tools

Merge lp://qastaging/~james-w/linaro-image-tools/metadata-from-config into lp://qastaging/linaro-image-tools/11.11

metadata-from-config
Merge into trunk

Proposed by James Westby on 2010-09-02

Status:	Merged
Approved by:	Michael Hudson-Doyle on 2010-09-03
Approved revision:	110
Merged at revision:	67
Proposed branch:	lp://qastaging/~james-w/linaro-image-tools/metadata-from-config
Merge into:	lp://qastaging/linaro-image-tools/11.11
Prerequisite:	lp://qastaging/~james-w/linaro-image-tools/architectures-from-config
Diff against target:	58 lines (+37/-0) 2 files modified hwpack/hardwarepack.py (+22/-0) hwpack/tests/test_hardwarepack.py (+15/-0)
To merge this branch:	bzr merge lp://qastaging/~james-w/linaro-image-tools/metadata-from-config
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Hudson-Doyle (community)		2010-09-02	Approve on 2010-09-03
Review via email: mp+34468@code.qastaging.launchpad.net

Description of the change

Hi,

A tiny branch to add a second constructor for Metdadata objects that
allows them to be created from their cousin, the Config object,
with a couple of other items specified.

Version doesn't go in the config, so has to be specified externally.

While architectures are in the configuration, we want to select a
single one for the particular hardware pack that is being built.

Thanks,

James

lp://qastaging/~james-w/linaro-image-tools/metadata-from-config updated on 2010-09-02

109. By James Westby on 2010-09-02: Add a docstring for from_config.
110. By James Westby on 2010-09-02: Merged architectures-from-config into metadata-from-config.

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2010-09-03:

You could check that the supplied architecture is in the config. Otherwise fine.

review: Approve

Revision history for this message

James Westby (james-w) wrote on 2010-09-03:

On Fri, 03 Sep 2010 05:07:42 -0000, Michael Hudson <email address hidden> wrote:
> Review: Approve
> You could check that the supplied architecture is in the config. Otherwise fine.

I wanted to avoid that, as there may be an option in the future to force
building for a different architecture than the config specifies, so I
went with the simpler code.

Thanks,

James