Merge lp://qastaging/~james-w/tarmac/commit-message into lp://qastaging/tarmac
Status: | Rejected |
---|---|
Rejected by: | dobey |
Proposed branch: | lp://qastaging/~james-w/tarmac/commit-message |
Merge into: | lp://qastaging/tarmac |
Prerequisite: | lp://qastaging/~james-w/tarmac/utf8 |
Diff against target: | 0 lines |
To merge this branch: | bzr merge lp://qastaging/~james-w/tarmac/commit-message |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey | Disapprove | ||
Paul Hummer | Pending | ||
Review via email:
|
Description of the change
This adds the commit message plugin that CA used to set the [r=<reviewer>] and [bug=] things.
It probably isn't needed with the commit message template plugin.
(from the u1 fork)
Unmerged revisions
- 422. By James Westby
-
Merged utf8 into commit-message.
- 421. By James Westby
-
Remove the commit plugin.
- 420. By James Westby
-
Merged utf8 into commit-message.
- 419. By James Westby
-
Merged utf8 into commit-message.
- 418. By James Westby
-
Merged utf8 into commit-message.
- 417. By James Westby
-
Merged utf8 into commit-message.
- 416. By James Westby
-
Add the commit message plugin that sets [r=<reviewer>] and bug info.
- 415. By James Westby
-
Decode stderr/stdout from the command, ignoring errors.
We were seeing UnicodeDecodeErrors in Jenkins on occaision, so
we changed the code to be more robust, and to discard anything
that couldn't be decoded from utf-8. - 414. By Sidnei da Silva
-
- Disable lightweight checkouts
- 413. By Sidnei da Silva
-
- Oops, target can be None here.
There is already a commit message formatting plug-in in Tarmac. This one breaks the default commit message handling, isn't enabled via a config option, and duplicates functionality already in the commitmessage plug-in, but doesn't work with multiple reviewers. It also has no license header, or tests.