update notifier

Merge lp://qastaging/~james-w/update-notifier/bug-403192 into lp://qastaging/update-notifier/ubuntu

  1. bug-403192
  2. Merge into ubuntu
Proposed by James Westby
Status: Merged
Approved by: James Westby
Approved revision: 495
Merge reported by: Michael Vogt
Merged at revision: not available
Proposed branch: lp://qastaging/~james-w/update-notifier/bug-403192
Merge into: lp://qastaging/update-notifier/ubuntu
Diff against target: None lines
To merge this branch: bzr merge lp://qastaging/~james-w/update-notifier/bug-403192
Reviewer Review Type Date Requested Status
James Westby (community) Disapprove
Review via email: mp+10096@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Fix for bug 403192.

However, I'm not sure exiting in this situation is the best idea.
Running without cdrom checking is better than not running at all
isn't it?

Thanks,

James

Revision history for this message
James Westby (james-w) :
review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/gdu.c'
2--- src/gdu.c 2009-07-08 15:22:36 +0000
3+++ src/gdu.c 2009-08-13 13:10:38 +0000
4@@ -215,6 +215,8 @@
5 up_do_hal_init (UpgradeNotifier *un)
6 {
7 GduPool *pool = gdu_pool_new ();
8+ if (!pool)
9+ return FALSE;
10 g_signal_connect (pool, "device_changed", (GCallback)up_device_changed, un);
11 // now check what devices we have
12 up_check_mounted_devices(pool, un);

Subscribers

People subscribed via source and target branches

to all changes: