Juju Charms Collection
nova-compute package

Merge lp://qastaging/~jamesbeedy/charms/trusty/nova-compute/add-iface-support into lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next

  1. Trusty Tahr (14.04)
  2. add-iface-support
  3. Merge into next
Proposed by james beedy
Status: Superseded
Proposed branch: lp://qastaging/~jamesbeedy/charms/trusty/nova-compute/add-iface-support
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next
Diff against target: 170 lines (+110/-0)
5 files modified
README.md (+30/-0)
config.yaml (+15/-0)
hooks/nova_compute_hooks.py (+4/-0)
hooks/nova_compute_utils.py (+48/-0)
templates/ethN (+13/-0)
To merge this branch: bzr merge lp://qastaging/~jamesbeedy/charms/trusty/nova-compute/add-iface-support
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Antonio Rosales Pending
James Page Pending
Liam Young Pending
Review via email: mp+274149@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-10-12.

Commit message

Adds ability to configure user defined network interfaces.

Description of the change

Adds ability to configure user defined network interfaces.

Added template for network interface config file in templates called ethN.
Added gen_interfaces() func to nova_compute_utils.py, called from
install hook.
Added import of yaml package to nova_compute_utils.py to facilitate
the parsing of string -> dict in gen_interfaces.
Added 'network-interfaces' and 'up-network-interfaces' parameters to
config.yaml.
Modified README.md to reflect docs on new params.

Partially fixes bug #1505064

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #11712 nova-compute-next for jamesbeedy mp274104
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/12763471/
Build: http://10.245.162.77:8080/job/charm_lint_check/11712/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #10895 nova-compute-next for jamesbeedy mp274104
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/10895/

lp://qastaging/~jamesbeedy/charms/trusty/nova-compute/add-iface-support updated
188. By james beedy

Fix python negation syntax

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #11715 nova-compute-next for jamesbeedy mp274149
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/12763574/
Build: http://10.245.162.77:8080/job/charm_lint_check/11715/

lp://qastaging/~jamesbeedy/charms/trusty/nova-compute/add-iface-support updated
189. By james beedy

Insert whitespace after ','

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #10898 nova-compute-next for jamesbeedy mp274149
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/10898/

lp://qastaging/~jamesbeedy/charms/trusty/nova-compute/add-iface-support updated
190. By james beedy

Removed trailing blank line in ethN

191. By james beedy

Removed trailing whitespace

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #7279 nova-compute-next for jamesbeedy mp274104
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12764369/
Build: http://10.245.162.77:8080/job/charm_amulet_test/7279/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #7282 nova-compute-next for jamesbeedy mp274149
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12764515/
Build: http://10.245.162.77:8080/job/charm_amulet_test/7282/

Unmerged revisions

191. By james beedy

Removed trailing whitespace

190. By james beedy

Removed trailing blank line in ethN

189. By james beedy

Insert whitespace after ','

188. By james beedy

Fix python negation syntax

187. By james beedy

Clearify gen_interfaces() description comment.

186. By james beedy

Repositioned iface_source_stanza_all outside of for loop.

185. By james beedy

Fix line length.

184. By james beedy

Fix typo

183. By james beedy

Modified comment to be more explicit in gen_interfaces.

182. By james beedy

Modified templates/ethN to reflect available params.

Removed interface-gateway, interface-nameservers, and
interface-dns-search from available params.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches