Merge lp://qastaging/~jamesh/camera-app/pre-cache-video-thumbnails into lp://qastaging/camera-app
Status: | Merged |
---|---|
Approved by: | Florian Boucault |
Approved revision: | 582 |
Merged at revision: | 587 |
Proposed branch: | lp://qastaging/~jamesh/camera-app/pre-cache-video-thumbnails |
Merge into: | lp://qastaging/camera-app |
Diff against target: |
75 lines (+30/-0) 3 files modified
GalleryView.qml (+26/-0) GalleryViewLoader.qml (+3/-0) camera-app.qml (+1/-0) |
To merge this branch: | bzr merge lp://qastaging/~jamesh/camera-app/pre-cache-video-thumbnails |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Florian Boucault (community) | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email: mp+273515@code.qastaging.launchpad.net |
Commit message
After shooting a video, request a thumbnail so that it will be available in the cache when needed (e.g. by the Gallery or Dash).
Description of the change
Due to the bad performance of thumbnailing H.264 video files (on the order of a 1.4 seconds) I started investigating whether we could improve the user experience with a modification to camera-app.
This branch requests a small thumbnail after shooting a video with the camera-app, which will prime the thumbnailer-
With this patch applied and an updated camera-app installed on my phone, I can see a thumbnail request in ~/.cache/
It wasn't clear where best to put this code, so if there is a better location I can update the branch.
FAILED: Continuous integration, rev:581 jenkins. qa.ubuntu. com/job/ camera- app-ci/ 434/ jenkins. qa.ubuntu. com/job/ camera- app-vivid- amd64-ci/ 130 jenkins. qa.ubuntu. com/job/ camera- app-vivid- armhf-ci/ 130 jenkins. qa.ubuntu. com/job/ camera- app-vivid- armhf-ci/ 130/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ camera- app-vivid- i386-ci/ 130 jenkins. qa.ubuntu. com/job/ generic- click-autopilot -vivid- touch/275 jenkins. qa.ubuntu. com/job/ generic- click-autopilot -runner- mako/929 jenkins. qa.ubuntu. com/job/ generic- click-builder- vivid-armhf/ 756 s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 23984
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/camera- app-ci/ 434/rebuild
http://