mediascanner2

Merge lp://qastaging/~jamesh/mediascanner2/zesty-thumbnails into lp://qastaging/mediascanner2

  1. zesty-thumbnails
  2. Merge into trunk
Proposed by James Henstridge
Status: Merged
Approved by: Michi Henning
Approved revision: 338
Merged at revision: 338
Proposed branch: lp://qastaging/~jamesh/mediascanner2/zesty-thumbnails
Merge into: lp://qastaging/mediascanner2
Diff against target: 46 lines (+15/-1)
2 files modified
src/extractor/TaglibExtractor.cc (+6/-1)
test/test_metadataextractor.cc (+9/-0)
To merge this branch: bzr merge lp://qastaging/~jamesh/mediascanner2/zesty-thumbnails
Reviewer Review Type Date Requested Status
Michi Henning (community) Approve
unity-api-1-bot continuous-integration Approve
Review via email: mp+312229@code.qastaging.launchpad.net

Commit message

Correctly detect embedded art in Vorbis files with TagLib 1.11.

Description of the change

Correctly detect embedded art in Vorbis files with TagLib 1.11.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:338
https://jenkins.canonical.com/unity-api-1/job/lp-mediascanner2-ci/14/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1223
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1230
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1014
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1014/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1014
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1014/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1014
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1014/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1014
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1014/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1014
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1014/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1014
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1014/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-mediascanner2-ci/14/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote :

Minor comment in-line.

Revision history for this message
James Henstridge (jamesh) :
Revision history for this message
Michi Henning (michihenning) wrote :

OK, this isn't urgent right now. As discussed, let's add checking the picture type in a separate MR.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches