Google Documents Lens

Merge lp://qastaging/~jamesh/unity-scope-gdrive/previews into lp://qastaging/~submarine/unity-scope-gdrive/libunity-7-compatible

previews
Merge into libunity-7-compatible

Proposed by James Henstridge on 2013-05-04

Status:	Merged
Approved by:	Michal Hruby on 2013-05-09
Approved revision:	52
Merged at revision:	47
Proposed branch:	lp://qastaging/~jamesh/unity-scope-gdrive/previews
Merge into:	lp://qastaging/~submarine/unity-scope-gdrive/libunity-7-compatible
Diff against target:	534 lines (+290/-86) 6 files modified debian/control (+7/-0) debian/rules (+3/-0) gdrive.scope (+1/-1) test_scope.py (+142/-0) unity-scope-gdrive.service (+1/-1) unity_gdrive_daemon.py (+136/-84)
To merge this branch:	bzr merge lp://qastaging/~jamesh/unity-scope-gdrive/previews
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michal Hruby (community)		2013-05-04	Approve on 2013-05-09
PS Jenkins bot (community)	continuous-integration		Approve on 2013-05-09
Review via email: mp+162505@code.qastaging.launchpad.net

Commit message

Convert to the new scope API and add a preview.

Description of the change

Convert scope to new API, and add a simple preview showing author, modification date and whether the document has been starred or shared.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-05-04:

PASSED: Continuous integration, rev:49
http://jenkins.qa.ubuntu.com/job/submarine-unity-scope-gdrive-libunity-7-compatible-ci/3/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/submarine-unity-scope-gdrive-libunity-7-compatible-raring-amd64-ci/3

Click here to trigger a rebuild:
http://s-jenkins:8080/job/submarine-unity-scope-gdrive-libunity-7-compatible-ci/3/rebuild

review: Approve (continuous-integration)

Revision history for this message

Michal Hruby (mhr3) wrote on 2013-05-07:

Could we get some tests? Or is that too complex with the authentication?

review: Needs Information

lp://qastaging/~jamesh/unity-scope-gdrive/previews updated on 2013-05-08

50. By James Henstridge on 2013-05-08: Use InfoHint to construct the preview.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-05-08:

PASSED: Continuous integration, rev:50
http://jenkins.qa.ubuntu.com/job/submarine-unity-scope-gdrive-libunity-7-compatible-ci/4/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/submarine-unity-scope-gdrive-libunity-7-compatible-raring-amd64-ci/4

Click here to trigger a rebuild:
http://s-jenkins:8080/job/submarine-unity-scope-gdrive-libunity-7-compatible-ci/4/rebuild

review: Approve (continuous-integration)

lp://qastaging/~jamesh/unity-scope-gdrive/previews updated on 2013-05-09

51. By James Henstridge on 2013-05-09

Add a test for the search functionality. Unfortunately we need to use a
stub document since GData.Parsable.new_from_xml() segfaults for
GData.Feed subtypes.

The preview test is also skipped because I can't initialise the metadata
dictionary.

52. By James Henstridge on 2013-05-09

Enable tests in packaging.

Revision history for this message

James Henstridge (jamesh) wrote on 2013-05-09:

I've added some basic tests for the search functionality, although it stubs out all the account discovery code and provides a fake DocumentsEntry class.

My original plan was to use GData.Parsable.new_from_xml() to build the feed from some sample XML, but that segfaults the interpreter. A quick poke with GDB shows that this wouldn't work from C either: it looks like you can only decode into GData.Feed subclasses from the query code path.

The previewer test is also disabled because I wasn't able to initialise Unity.ScopeResult.metadata from Python in a way that wouldn't cause it to segfault.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-05-09:

PASSED: Continuous integration, rev:52
http://jenkins.qa.ubuntu.com/job/submarine-unity-scope-gdrive-libunity-7-compatible-ci/5/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/submarine-unity-scope-gdrive-libunity-7-compatible-raring-amd64-ci/5