Unity Media Scanner Scope

Code review comment for lp://qastaging/~jamesh/unity-scope-mediascanner/bug-1367334

  1. bug-1367334
  2. Merge into trunk
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Looking good.

There are only two minor points in test-music-scope.cpp that are not related to this MR but let's fix them at the same time. On line 34 NULL is used instead of nullptr and MusicScopeTest has virtual functions but not a virtual destructor.

review: Needs Fixing

« Back to merge proposal