Unity Scopes Scope

Merge lp://qastaging/~jamesh/unity-scope-scopes/category-renderer into lp://qastaging/unity-scope-scopes

  1. category-renderer
  2. Merge into trunk
Proposed by James Henstridge
Status: Merged
Approved by: Michal Hruby
Approved revision: 16
Merged at revision: 13
Proposed branch: lp://qastaging/~jamesh/unity-scope-scopes/category-renderer
Merge into: lp://qastaging/unity-scope-scopes
Prerequisite: lp://qastaging/~jamesh/unity-scope-scopes/scopes-api-0.3
Diff against target: 120 lines (+37/-21)
2 files modified
src/scopes-scope.cpp (+37/-19)
src/scopes.ini (+0/-2)
To merge this branch: bzr merge lp://qastaging/~jamesh/unity-scope-scopes/category-renderer
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+206146@code.qastaging.launchpad.net

Commit message

Use a custom category renderer, and update the preview to show the scope icon.

Description of the change

Add a custom category renderer to the scopes scope: rather than showing large artwork, use a mascot to the left of the description.

I've also updated the preview code to use add_component() to bind widget attributes to the result, and shown the scope icon in the preview as the header mascot.

To post a comment you must log in.
lp://qastaging/~jamesh/unity-scope-scopes/category-renderer updated
13. By James Henstridge

Fix widget type for art, and rename it from "screenshot" to "art", to
match the terminology in the scope metadata.

14. By James Henstridge

Add "publisher" key to result, and use it as subtitle in the category
renderer and preview header. Currently it is hard coded to "Canonical
Ltd", but should eventually come from scope metadata.

15. By James Henstridge

Rename publisher to author, as discussed on IRC.

16. By James Henstridge

Remove empty Icon and Art metadata keys.

Revision history for this message
Michal Hruby (mhr3) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: