Merge lp://qastaging/~jamesh/unity-scope-scopes/fake-result-categories into lp://qastaging/unity-scope-scopes
Proposed by
James Henstridge
| Status: | Merged |
|---|---|
| Approved by: | Michal Hruby |
| Approved revision: | 20 |
| Merged at revision: | 17 |
| Proposed branch: | lp://qastaging/~jamesh/unity-scope-scopes/fake-result-categories |
| Merge into: | lp://qastaging/unity-scope-scopes |
| Diff against target: |
169 lines (+108/-20) 1 file modified
src/scopes-scope.cpp (+108/-20) |
| To merge this branch: | bzr merge lp://qastaging/~jamesh/unity-scope-scopes/fake-result-categories |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
| Michi Henning (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add categories to the scopes scope results based on a hard coded mapping. This should eventually be handled through scope metadata.
Description of the change
Add some extra categories to the results from the scopes scope.
We don't currently have any information in the scope metadata to drive this categorisation, so for now there is a hard coded list in the code. This should obviously change after MWC.
To post a comment you must log in.
Revision history for this message
| James Henstridge (jamesh) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me. In general, I'm not sure that categories should be part of the metadata for a scope though. For some scopes, I imagine that the categories will actually determined by whatever data source the scope uses, so fixing the categories at scope installation time seems wrong?