Merge lp://qastaging/~jamesodhunt/snappy/show-upgrade-details into lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github
Proposed by
James Hunt
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://qastaging/~jamesodhunt/snappy/show-upgrade-details |
| Merge into: | lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github |
| Diff against target: |
114 lines (+76/-0) 1 file modified
snappy/systemimage.go (+76/-0) |
| To merge this branch: | bzr merge lp://qastaging/~jamesodhunt/snappy/show-upgrade-details |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Vogt (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
There will be a follow-on MP to perform additional checks in the upgrader, but given the issues we've had in this area, I think there is value in adding this basic runtime safety check.
* snappy/
- showUpgradeDeta
(displayed if SNAPPY_DEBUG=1).
- checkUpgrade(): Basic test run unconditionally to ensure the upgrade
revision applied is as expected.
To post a comment you must log in.
Revision history for this message
| Michael Vogt (mvo) wrote | # |
Revision history for this message
| James Hunt (jamesodhunt) | # |
Revision history for this message
| Michael Vogt (mvo) | # |
Unmerged revisions
- 154. By James Hunt
-
* snappy/
systemimage. go:
- showUpgradeDetails(): Display basic debug showing planned upgrade details
(displayed if SNAPPY_DEBUG=1).
- checkUpgrade(): Basic test run unconditionally to ensure the upgrade
revision applied is as expected.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for this branch.
I added some inline comments. I also get a test failure when I run this branch.