Ubuntu
vim package

Merge lp://qastaging/~jamesodhunt/ubuntu/natty/vim/add-upstart-syntax into lp://qastaging/ubuntu/natty/vim

  1. Natty (11.04)
  2. add-upstart-syntax
  3. Merge into natty
Proposed by James Hunt
Status: Merged
Merge reported by: Colin Watson
Merged at revision: not available
Proposed branch: lp://qastaging/~jamesodhunt/ubuntu/natty/vim/add-upstart-syntax
Merge into: lp://qastaging/ubuntu/natty/vim
Diff against target: 130 lines (+107/-0)
3 files modified
debian/changelog (+8/-0)
runtime/filetype.vim (+4/-0)
runtime/syntax/upstart.vim (+95/-0)
To merge this branch: bzr merge lp://qastaging/~jamesodhunt/ubuntu/natty/vim/add-upstart-syntax
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Dave Walker (community) Needs Fixing
Review via email: mp+52440@code.qastaging.launchpad.net

Description of the change

* runtime/syntax/upstart.vim: New syntax file for Upstart.
* runtime/filetype.vim: Updated to recognise Upstart configuration
  files.

To post a comment you must log in.
Revision history for this message
Dave Walker (davewalker) wrote :

Oooo, nice addition.

Annoyingly, the package it's been based against isn't the latest version in natty. It seems lp:ubuntu/natty failed to import successfully, and is therefore outdated.

The latest version in Natty is currently, 2:7.3.035+hg~8fdc12103333-1ubuntu3. If one of the package-import maintainers can fix this, it shouldn't be too bad to rebase this branch.

I would suggest submitting this to Debian, as I'm sure the feature will be useful there - and will avoid increasing the delta next merge.

Would you consider this patch a new feature?

review: Needs Fixing
Revision history for this message
Colin Watson (cjwatson) wrote :

I've run into the package-import problem with vim before, and have generally just been doing uploads outside branches for the time being. I'm happy to do so again for this change, and will handle the rebasing.

You certainly should submit this to Debian. Relevant resources:

  http://www.debian.org/Bugs/Reporting
  https://wiki.ubuntu.com/Debian/Usertagging

While I suppose this is technically a feature, I don't think there's any need to worry about it with respect to feature freeze. It's pretty unlikely to break anything.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: