Ubuntu
upstart package

Merge lp://qastaging/~jamesodhunt/ubuntu/oneiric/upstart/fixes-for-user-sessions into lp://qastaging/ubuntu/oneiric/upstart

  1. Oneiric (11.10)
  2. fixes-for-user-sessions
  3. Merge into oneiric
Proposed by James Hunt
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp://qastaging/~jamesodhunt/ubuntu/oneiric/upstart/fixes-for-user-sessions
Merge into: lp://qastaging/ubuntu/oneiric/upstart
Diff against target: 1957 lines (+991/-211)
13 files modified
ChangeLog (+34/-0)
TESTING.sessions (+38/-12)
debian/changelog (+7/-0)
init/job_process.c (+108/-58)
init/job_process.h (+1/-0)
init/man/init.5 (+16/-2)
init/session.c (+50/-9)
init/session.h (+13/-11)
po/en@boldquot.po (+54/-39)
po/en@quot.po (+54/-39)
po/upstart.pot (+54/-39)
util/man/initctl.8 (+9/-2)
util/tests/test_user_sessions.sh (+553/-0)
To merge this branch: bzr merge lp://qastaging/~jamesodhunt/ubuntu/oneiric/upstart/fixes-for-user-sessions
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Ubuntu branches Pending
Review via email: mp+69125@code.qastaging.launchpad.net

Description of the change

Quite a bit of change wrt user sessions. If someone could check my fixup for <email address hidden> and <email address hidden>, that'd be great! Thanks.

The details:

  * init/man/init.5: Explain that symbolic links are not supported.
  * init/session.c: session_from_dbus(): Handle case where a users
    home directory is changed or where a uid is re-used for a
    different username.
  * init/session.h: Updated comments for Session object.
  * TESTING.sessions: Updated with information on user sessions.
  * init/job_process.c:
    - job_process_spawn():
      - Change group before user and do it as early as possible.
      - Ensure non-priv user is able to read script fd. Default system
        behaviour is seemingly not consistent/defined, so force it
        to be (LP: #813052)
      - Ensure cwd for user job is home directory by default.
    - job_process_error_read():
      - Added handling for JOB_PROCESS_ERROR_SETUID and
        JOB_PROCESS_ERROR_SETGID (LP: #807293).
      - Added new entry for JOB_PROCESS_ERROR_CHOWN.
  * init/job_process.h:
    - Added entry for JOB_PROCESS_ERROR_CHOWN in JobProcessErrorType.
  * init/man/init.5: Update for user jobs explaining behaviour of stanzas
    which manipulate system resource limits and when the init
    daemon reads the users job directory.
  * util/tests/test_user_sessions.sh: New script for testing user sessions
    (NOTE: this is *NOT* run automatically).

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Looks good, I do a testbuild now and install it.

As for the <email address hidden> fixups this looks ok. Usually it should be enough to just
refresh the po files. The .gmo stuff is autogenerated and not part of the bzr tree.

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

setting to merged since that got approved, the ubuntu Vcs seems outdated for some reason, I pointed it to slangasek

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: