Merge lp://qastaging/~jamesodhunt/ubuntu/raring/gnome-session/gnome-session-job-emit-desktop-event into lp://qastaging/ubuntu/raring/gnome-session

Proposed by James Hunt
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp://qastaging/~jamesodhunt/ubuntu/raring/gnome-session/gnome-session-job-emit-desktop-event
Merge into: lp://qastaging/ubuntu/raring/gnome-session
Diff against target: 33 lines (+15/-0)
2 files modified
debian/changelog (+7/-0)
debian/gnome-session.user-session.upstart (+8/-0)
To merge this branch: bzr merge lp://qastaging/~jamesodhunt/ubuntu/raring/gnome-session/gnome-session-job-emit-desktop-event
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+153558@code.qastaging.launchpad.net

Description of the change

Make gnome-session upstart job emit 'desktop' event.

By providing a level of abstraction, we can encourage users who wish to create their own Upstart jobs to specify:

    start on desktop

This is better than 'start on started gnome-session' since:

- it's less typing ;-)
- it will allow other flavours who wish to opt-in and provide an Upstart-managed session to emit the event from whatever upstart job they create to start some core part of their desktop (maybe ksession for KDE, etc).
- it makes users jobs portable between different desktop-environments.

By providing the DESKTOP_SESSION variable, user jobs could potentially change their behaviour based on whichever desktop environment they get started in.

To post a comment you must log in.
Revision history for this message
Stéphane Graber (stgraber) wrote :

I think you're missing "emits desktop" in there, but besides that, looks good.

Revision history for this message
James Hunt (jamesodhunt) wrote :

Good catch! ;-) Branch updated.

222. By James Hunt

Make gnome-session upstart job emit 'desktop-start' and
'desktop-end' events.

Revision history for this message
James Hunt (jamesodhunt) wrote :

Updated to emit 'desktop-start' and 'desktop-end' events which users could use in lieu of 'startup' or 'xsession' to ensure their jobs only run within a fully operational desktop environment:

start on desktop-start
stop on desktop-end

Revision history for this message
Sebastien Bacher (seb128) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

(I've commited the update to the packaging branch as well: lp:~ubuntu-desktop/gnome-session/ubuntu/)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: