Merge lp://qastaging/~jamesodhunt/ubuntu/raring/gnome-session/gnome-session-job-emit-desktop-event into lp://qastaging/ubuntu/raring/gnome-session
Status: | Merged |
---|---|
Merge reported by: | Sebastien Bacher |
Merged at revision: | not available |
Proposed branch: | lp://qastaging/~jamesodhunt/ubuntu/raring/gnome-session/gnome-session-job-emit-desktop-event |
Merge into: | lp://qastaging/ubuntu/raring/gnome-session |
Diff against target: |
33 lines (+15/-0) 2 files modified
debian/changelog (+7/-0) debian/gnome-session.user-session.upstart (+8/-0) |
To merge this branch: | bzr merge lp://qastaging/~jamesodhunt/ubuntu/raring/gnome-session/gnome-session-job-emit-desktop-event |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu branches | Pending | ||
Review via email:
|
Description of the change
Make gnome-session upstart job emit 'desktop' event.
By providing a level of abstraction, we can encourage users who wish to create their own Upstart jobs to specify:
start on desktop
This is better than 'start on started gnome-session' since:
- it's less typing ;-)
- it will allow other flavours who wish to opt-in and provide an Upstart-managed session to emit the event from whatever upstart job they create to start some core part of their desktop (maybe ksession for KDE, etc).
- it makes users jobs portable between different desktop-
By providing the DESKTOP_SESSION variable, user jobs could potentially change their behaviour based on whichever desktop environment they get started in.
I think you're missing "emits desktop" in there, but besides that, looks good.