Juju Charms Collection
cinder package

Code review comment for lp://qastaging/~jason-hobbs/charms/trusty/cinder/force-vgreduce

  1. Trusty Tahr (14.04)
  2. force-vgreduce
  3. Merge into next
Revision history for this message
Jason Hobbs (jason-hobbs) wrote :

> Jason, thanks for the code submission! There were some lint errors which need
> to be corrected and I've also added a few comments inline.

Thanks for the review. I fixed up the lint issues and got rid of the force_reduce_lvm_volume_group_missing(). reduce_lvm_volume_group_missing() now takes an optional list of extra args to pass to vgreduce.

« Back to merge proposal