Merge lp://qastaging/~jason-hobbs/charms/trusty/odl-controller/add-unit-tests into lp://qastaging/~sdn-charmers/charms/trusty/odl-controller/trunk
Proposed by
Jason Hobbs
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~jason-hobbs/charms/trusty/odl-controller/add-unit-tests |
| Merge into: | lp://qastaging/~sdn-charmers/charms/trusty/odl-controller/trunk |
| Diff against target: |
324 lines (+275/-18) 4 files modified
hooks/odl_controller_utils.py (+26/-18) unit_tests/__init__.py (+3/-0) unit_tests/test_odl_controller_utils.py (+125/-0) unit_tests/test_utils.py (+121/-0) |
| To merge this branch: | bzr merge lp://qastaging/~jason-hobbs/charms/trusty/odl-controller/add-unit-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| SDN Charmers | Pending | ||
|
Review via email:
|
|||
Commit message
Add unit tests for the maven settings template generator.
Description of the change
Just a start on unit tests for odl controller, along with a minor refactor on one of the methods being tested. I copied test_utils.py from the nova-compute charm.
To post a comment you must log in.
Unmerged revisions
- 9. By Jason Hobbs
-
Add some docstrings.
- 8. By Jason Hobbs
-
One more unit test for no_proxy.
- 7. By Jason Hobbs
-
Finish adding unit tests for odl_controller_
utils. - 6. By Jason Hobbs
-
Continue adding unit tests.
- 5. By Jason Hobbs
-
Add first unit test for ODL utils.
- 4. By Jason Hobbs
-
Use early return from mvn_proxy_ctx().
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
