Merge lp://qastaging/~jason-hobbs/maas/add-option-to-disable-dhclient-on-all-interfaces into lp://qastaging/~maas-committers/maas/trunk
Proposed by
Jason Hobbs
Status: | Superseded |
---|---|
Proposed branch: | lp://qastaging/~jason-hobbs/maas/add-option-to-disable-dhclient-on-all-interfaces |
Merge into: | lp://qastaging/~maas-committers/maas/trunk |
Diff against target: |
189 lines (+65/-8) 5 files modified
src/maasserver/forms_settings.py (+10/-0) src/maasserver/models/config.py (+1/-0) src/metadataserver/api.py (+5/-3) src/metadataserver/models/commissioningscript.py (+22/-5) src/metadataserver/models/tests/test_noderesults.py (+27/-0) |
To merge this branch: | bzr merge lp://qastaging/~jason-hobbs/maas/add-option-to-disable-dhclient-on-all-interfaces |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | Approve | ||
Christian Reis (community) | Needs Information | ||
Review via email:
|
Commit message
Add an option to enable/disable DHCP discovery on unconfigured interfaces of commissioning nodes. By default, DHCP discovery on unconfigured interfaces of commissioning nodes is enabled.
Description of the change
This isn't the final solution for this bug but provides a way for users to avoid its behavior for now, if it causes them problems.
To post a comment you must log in.
Unmerged revisions
- 3279. By Jason Hobbs
-
review fix
- 3278. By Jason Hobbs
-
more removals.
- 3277. By Jason Hobbs
-
Don't display the enable DHCP on unconfigured interfaces option.
- 3276. By Jason Hobbs
-
Add a doctstring.
- 3275. By Jason Hobbs
-
fix test class name.
- 3274. By Jason Hobbs
-
add unit tests for get_builtin_
commissioning_ scripts( ). - 3273. By Jason Hobbs
-
Add a unit test for the view
- 3272. By Jason Hobbs
-
Add an option to enable/disable DHCP discovery on unconfigured interfaces of commissioning nodes.
I'm not sure about this one, and I certainly didn't expect to see this exposed via the UI. Some further thinking:
* For trunk, I'd like us to explore the "correct" fix of releasing the IP allocated (or experimenting with a custom dhcp probe client).
* For 1.7, I would accept a VERY SMALL patch that disables this. This patch is way too big.
What do you think?