Merge lp://qastaging/~jason-hobbs/maas/allow-hostname-change-while-allocated into lp://qastaging/~maas-committers/maas/trunk

Proposed by Jason Hobbs
Status: Merged
Approved by: Jason Hobbs
Approved revision: no longer in the source branch.
Merged at revision: 2699
Proposed branch: lp://qastaging/~jason-hobbs/maas/allow-hostname-change-while-allocated
Merge into: lp://qastaging/~maas-committers/maas/trunk
Diff against target: 74 lines (+10/-43)
2 files modified
src/maasserver/forms.py (+10/-12)
src/maasserver/tests/test_forms.py (+0/-31)
To merge this branch: bzr merge lp://qastaging/~jason-hobbs/maas/allow-hostname-change-while-allocated
Reviewer Review Type Date Requested Status
Jason Hobbs (community) Approve
Julian Edwards (community) Approve
Review via email: mp+227372@code.qastaging.launchpad.net

Commit message

Allow changing a hostname while a node is acquired.

Description of the change

This rolls back most of r1314. A similar check for "node started" instead of "node acquired" is expected to be added in the future, once MAAS grows the ability to track a node's start/stop state. In the mean time, I think it makes sense to be less restrictive and allow more use cases.

To post a comment you must log in.
Revision history for this message
Jason Hobbs (jason-hobbs) wrote :

We will revisit this towards the end of the sprint next week - there is a plan to implement acquired vs. acquired+started tracking in MAAS.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

I think this is fine, but please file a bug with the intended behaviour and XXX with a reference to it in the code.

review: Approve
Revision history for this message
Jason Hobbs (jason-hobbs) wrote :

Approving minor comment change.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.