Do

Merge lp://qastaging/~jassmith/do/docky-cursor-polling into lp://qastaging/do/0.8

Proposed by Jason Smith
Status: Merged
Merged at revision: not available
Proposed branch: lp://qastaging/~jassmith/do/docky-cursor-polling
Merge into: lp://qastaging/do/0.8
To merge this branch: bzr merge lp://qastaging/~jassmith/do/docky-cursor-polling
Reviewer Review Type Date Requested Status
David Siegel (community) Approve
Review via email: mp+2676@code.qastaging.launchpad.net
To post a comment you must log in.
815. By Jason Smith

Fix issue where docky's hover area didn't expand with the size of the dock

816. By Jason Smith

Make cursor timer respect dragging

817. By Jason Smith

Merge trunk

818. By Jason Smith

move icon position code to its own class
fix bug where text sometimes would not show up in right click menu

819. By Jason Smith

Make dragging icons on the dock a little more believable

820. By Jason Smith

cleanup how we use render flags a little

821. By Jason Smith

Make it obvious that certain items cant be moved

822. By Jason Smith

IconSize changes now when zoom percent changes

Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

AbstractMenuButtonArgs:
 Catalog.GetString (GLib.Markup.EscapeText (description)) -- think about what this means, it's wrong

Why so many new lines in UnregisterEvents?

The if/else in ResetCursorTimer should be changed to not repeat the Timeout.Add.

Wrap your comments to 80 cols.

At cursorMoveWarrantsDraw, you use unneeded ( ).

OnLeaveNotifyEvent has some very long lines.

HandleDragMotion has very long lines.

DockItemProvider Un/RegisterEvents has some extra newlines. OnWindowClosed/Opened has funky indentation.

Why is DockWindow Vanish doing so much ungrab work? Can't this go in Controller? Why is it Ungrabbing itself?

Why is ItemPositionProvider returning the DockItems of its ItemProvider, and not just exposing its ItemProvider? Why is it exposing a List instead of an IEnumerable, or ICollection?

IconZoomedPosition, IconUnzoomedPosition -- wrap your comments to 80col.

In DockPreferences, let the compiler add the <T> for you after Get and Set (you only need Set, not Set<bool>).

You Ungrab in Bezel -- seems like a good place, better than in the controller. Can you PresentWindow in Bezel too?

Fix these things, then merge.

Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

Approved pending changes mentioned in review.

review: Approve
823. By Jason Smith

Fixes for merge

Subscribers

People subscribed via source and target branches