Merge lp://qastaging/~jassmith/do/docky-cursor-polling into lp://qastaging/do/0.8
Proposed by
Jason Smith
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp://qastaging/~jassmith/do/docky-cursor-polling |
Merge into: | lp://qastaging/do/0.8 |
To merge this branch: | bzr merge lp://qastaging/~jassmith/do/docky-cursor-polling |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Siegel (community) | Approve | ||
Review via email:
|
To post a comment you must log in.
AbstractMenuBut tonArgs: EscapeText (description)) -- think about what this means, it's wrong
Catalog.GetString (GLib.Markup.
Why so many new lines in UnregisterEvents?
The if/else in ResetCursorTimer should be changed to not repeat the Timeout.Add.
Wrap your comments to 80 cols.
At cursorMoveWarra ntsDraw, you use unneeded ( ).
OnLeaveNotifyEvent has some very long lines.
HandleDragMotion has very long lines.
DockItemProvider Un/RegisterEvents has some extra newlines. OnWindowClosed/ Opened has funky indentation.
Why is DockWindow Vanish doing so much ungrab work? Can't this go in Controller? Why is it Ungrabbing itself?
Why is ItemPositionPro vider returning the DockItems of its ItemProvider, and not just exposing its ItemProvider? Why is it exposing a List instead of an IEnumerable, or ICollection?
IconZoomedPosition, IconUnzoomedPos ition -- wrap your comments to 80col.
In DockPreferences, let the compiler add the <T> for you after Get and Set (you only need Set, not Set<bool>).
You Ungrab in Bezel -- seems like a good place, better than in the controller. Can you PresentWindow in Bezel too?
Fix these things, then merge.