Merge lp://qastaging/~jassmith/unity/unity.fix-monitor-tracking into lp://qastaging/unity
Proposed by
Jason Smith
| Status: | Merged |
|---|---|
| Approved by: | Jason Smith |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2004 |
| Proposed branch: | lp://qastaging/~jassmith/unity/unity.fix-monitor-tracking |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
11 lines (+1/-1) 1 file modified
plugins/unityshell/src/BamfLauncherIcon.cpp (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~jassmith/unity/unity.fix-monitor-tracking |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Penhey (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Restores accidentally commented code. This should have been uncommented before merge previously, but was missed. Fixes bug where launcher didn't properly reflect window states on initial startup
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
<thumper> jason: ok... I'm going to ask the question you love to hate
<jason> no there is no bug
<thumper> jason: what is the behaviour before the commit, and how do I know it is fixed?
<jason> oh that question
<jason> before:
<jason> sometimes when you started an application unity would think it was on monitor 0 instead of monitor 1 because of a race condition
<jason> after:
<jason> we check, thus eliminating the race condition
<thumper> and to reproduce the behaviour?
<thomi> possible switcher bug that should be easy to fix: https:/
<jason> thumper, restart unity enough times to eventually trigger the race condition