Checkbox

Merge lp://qastaging/~javier.collado/checkbox/bug921576 into lp://qastaging/checkbox

  1. bug921576
  2. Merge into trunk
Proposed by Javier Collado
Status: Merged
Merged at revision: 1197
Proposed branch: lp://qastaging/~javier.collado/checkbox/bug921576
Merge into: lp://qastaging/checkbox
Diff against target: 36 lines (+7/-2)
2 files modified
debian/changelog (+5/-1)
setup.py (+2/-1)
To merge this branch: bzr merge lp://qastaging/~javier.collado/checkbox/bug921576
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+90121@code.qastaging.launchpad.net

Description of the change

This change fixes the error found when trying to build a binary package from source.

After some debugging, it's been found that

  * checkbox_install_data.run method is executed multiple times (one for each python version available).
  * a call to os.symlink in that method failed the second time because the symbolic link already existed

To fix this, a check has been added to executed os.symlink only if the destination doesn't exist.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Thanks so much for fixing this! Merging!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches