Ubuntu
flash-kernel package

Merge ~jawn-smith/ubuntu/+source/flash-kernel:ubuntu/devel into ubuntu/+source/flash-kernel:ubuntu/devel

Git
lp:~jawn-smith/ubuntu/+source/flash-kernel
ubuntu/devel
Merge into ubuntu/devel

Proposed by William Wilson on 2022-08-26

Status:	Needs review
Proposed branch:	~jawn-smith/ubuntu/+source/flash-kernel:ubuntu/devel
Merge into:	ubuntu/+source/flash-kernel:ubuntu/devel
Diff against target:	30 lines (+9/-2) 2 files modified debian/changelog (+7/-0) functions (+2/-2)
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Dave Jones (community)		2022-08-26	Approve on 2022-09-08
Review via email: mp+429001@code.qastaging.launchpad.net

Description of the change

When running in a chroot, flash-kernel should exit cleanly as it does when running in a container.

Revision history for this message

Dave Jones (waveform) wrote on 2022-09-08:

Discussed this with Alex, who first introduced FK_FORCE_CONTAINER; he'll need to update livecd-rootfs which is the only thing using FK_FORCE_CONTAINER externally at the moment but otherwise there don't appear to be any problems with extending the exception to cover chroots as well.

review: Approve

Revision history for this message

Dave Jones (waveform) wrote on 2022-09-08:

Follow up comment from Alex: he'd actually favour introducing a separate var to avoid having to change the external interface.

Any chance you could post a follow up commit to implement that (presumably as FK_FORCE_CHROOT)? Given that wouldn't require any coordination with livecd-rootfs I could sponsor that change immediately.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.