Code review comment for ~jawn-smith/ubuntu/+source/livecd-rootfs:oem-user-check

Revision history for this message
Dave Jones (waveform) wrote :

Looks reasonable to me in the context of the proposed ubuntu-raspi-settings-desktop changes [1]. We *could* remove the lines under the assumption that the postinst will take care of them but that potentially breaks other pre-installed desktop images (I'm not sure there are any official ones yet, but there might be so this is the safer option).

Also, better to stick hacks like this in the pile-of-hacks-known-as-livecd-rootfs than anywhere else under the assumption that many of them will disappear in a puff of ubuntu-image-flavoured-smoke in the coming cycle.

[1]: https://dpaste.com/CX2JGNYGK

review: Approve

« Back to merge proposal